linux-kernel - Re: [PATCH] wifi: mwifiex: Fix oob check condition in mwifiex_process_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEXTbpdqhxWVMSHz-8+=50_qd1UViKvD5YZY08=RFMBu5E6b2A@mail.gmail.com>
Date:   Thu, 7 Sep 2023 17:26:10 +0800
From:   Pin-yen Lin <treapking@...omium.org>
To:     Matthew Wang <matthewmwang@...omium.org>
Cc:     linux-wireless@...r.kernel.org,
        Brian Norris <briannorris@...omium.org>,
        Polaris Pi <pinkperfect2021@...il.com>,
        linux-kernel@...r.kernel.org, Kalle Valo <kvalo@...nel.org>
Subject: Re: [PATCH] wifi: mwifiex: Fix oob check condition in mwifiex_process_rx_packet

Hi Matthew,

On Thu, Sep 7, 2023 at 5:10 PM Matthew Wang <matthewmwang@...omium.org> wrote:
>
> > -       if ((!memcmp(&rx_pkt_hdr->rfc1042_hdr, bridge_tunnel_header,
> > -                    sizeof(bridge_tunnel_header))) ||
> > -           (!memcmp(&rx_pkt_hdr->rfc1042_hdr, rfc1042_header,
> > -                    sizeof(rfc1042_header)) &&
> > -            ntohs(rx_pkt_hdr->rfc1042_hdr.snap_type) != ETH_P_AARP &&
> > -            ntohs(rx_pkt_hdr->rfc1042_hdr.snap_type) != ETH_P_IPX)) {
> > +       if (sizeof(rx_pkt_hdr) + rx_pkt_off <= skb->len &&
>
> sizeof(*rx_pkt_hdr)?

Thanks for catching this. I'll upload a v2 for this.

Best,
Pin-yen