linux-kernel - Re: [PATCH] wifi: mwifiex: Fix oob check condition in mwifiex_process_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABRiz0r8qHgx-4b7QdCj6iz9FDsyChznEHOn5eByVoUYuLa-PQ@mail.gmail.com>
Date:   Thu, 7 Sep 2023 11:10:44 +0200
From:   Matthew Wang <matthewmwang@...omium.org>
To:     Pin-yen Lin <treapking@...omium.org>
Cc:     linux-wireless@...r.kernel.org,
        Brian Norris <briannorris@...omium.org>,
        Polaris Pi <pinkperfect2021@...il.com>,
        linux-kernel@...r.kernel.org, Kalle Valo <kvalo@...nel.org>
Subject: Re: [PATCH] wifi: mwifiex: Fix oob check condition in mwifiex_process_rx_packet

> -       if ((!memcmp(&rx_pkt_hdr->rfc1042_hdr, bridge_tunnel_header,
> -                    sizeof(bridge_tunnel_header))) ||
> -           (!memcmp(&rx_pkt_hdr->rfc1042_hdr, rfc1042_header,
> -                    sizeof(rfc1042_header)) &&
> -            ntohs(rx_pkt_hdr->rfc1042_hdr.snap_type) != ETH_P_AARP &&
> -            ntohs(rx_pkt_hdr->rfc1042_hdr.snap_type) != ETH_P_IPX)) {
> +       if (sizeof(rx_pkt_hdr) + rx_pkt_off <= skb->len &&

sizeof(*rx_pkt_hdr)?