[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230907082446.a4o46vka2vtes3h4@localhost>
Date: Thu, 7 Sep 2023 10:24:46 +0200
From: Joel Granados <j.granados@...sung.com>
To: Ingo Molnar <mingo@...nel.org>
CC: Dave Hansen <dave.hansen@...el.com>,
Luis Chamberlain <mcgrof@...nel.org>, <willy@...radead.org>,
<josh@...htriplett.org>, Kees Cook <keescook@...omium.org>,
Iurii Zaikin <yzaikin@...gle.com>,
Heiko Carstens <hca@...ux.ibm.com>,
Vasily Gorbik <gor@...ux.ibm.com>,
Alexander Gordeev <agordeev@...ux.ibm.com>,
Christian Borntraeger <borntraeger@...ux.ibm.com>,
Sven Schnelle <svens@...ux.ibm.com>,
Gerald Schaefer <gerald.schaefer@...ux.ibm.com>,
Russell King <linux@...linux.org.uk>,
Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
Dave Hansen <dave.hansen@...ux.intel.com>, <x86@...nel.org>,
"H. Peter Anvin" <hpa@...or.com>,
Andy Lutomirski <luto@...nel.org>,
Paul Walmsley <paul.walmsley@...ive.com>,
Palmer Dabbelt <palmer@...belt.com>,
Albert Ou <aou@...s.berkeley.edu>,
Michael Ellerman <mpe@...erman.id.au>,
Nicholas Piggin <npiggin@...il.com>,
Christophe Leroy <christophe.leroy@...roup.eu>,
Guo Ren <guoren@...nel.org>, <linux-fsdevel@...r.kernel.org>,
<linux-s390@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-riscv@...ts.infradead.org>, <linuxppc-dev@...ts.ozlabs.org>,
<linux-ia64@...r.kernel.org>, <linux-csky@...r.kernel.org>
Subject: Re: [PATCH 3/8] arch/x86: Remove sentinel elem from ctl_table
arrays
On Wed, Sep 06, 2023 at 11:58:47PM +0200, Ingo Molnar wrote:
>
> * Dave Hansen <dave.hansen@...el.com> wrote:
>
> > On 9/6/23 03:03, Joel Granados via B4 Relay wrote:
> > > This commit comes at the tail end of a greater effort to remove the
> > > empty elements at the end of the ctl_table arrays (sentinels) which
> > > will reduce the overall build time size of the kernel and run time
> > > memory bloat by ~64 bytes per sentinel (further information Link :
> > > https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/)
> > >
> > > Remove sentinel element from sld_sysctl and itmt_kern_table.
> >
> > There's a *LOT* of content to read for a reviewer to figure out what's
> > going on here between all the links. I would have appreciated one more
> > sentence here, maybe:
> >
> > This is now safe because the sysctl registration code
> > (register_sysctl()) implicitly uses ARRAY_SIZE() in addition
> > to checking for a sentinel.
> >
> > That needs to be more prominent _somewhere_. Maybe here, or maybe in
> > the cover letter, but _somewhere_.
> >
> > That said, feel free to add this to the two x86 patches:
> >
> > Acked-by: Dave Hansen <dave.hansen@...ux.intel.com> # for x86
>
> Absolutely needs to be in the title as well, something like:
>
> arch/x86: Remove now superfluous sentinel elem from ctl_table arrays
Done. Will wait to see if other ppl have more comments to send out V2
Thx.
>
> With that propagated into the whole series:
>
> Reviewed-by: Ingo Molnar <mingo@...nel.org>
>
> Thanks,
>
> Ingo
--
Joel Granados
Download attachment "signature.asc" of type "application/pgp-signature" (660 bytes)
Powered by blists - more mailing lists