linux-kernel - Re: [PATCH v3 1/6] soc/tegra: fuse: Refactor resource mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZPnda7q0Af8ud74v@smile.fi.intel.com>
Date:   Thu, 7 Sep 2023 17:25:47 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Kartik <kkartik@...dia.com>
Cc:     thierry.reding@...il.com, jonathanh@...dia.com, sumitg@...dia.com,
        arnd@...db.de, pshete@...dia.com, digetx@...il.com,
        petlozup@...dia.com, windhl@....com, frank.li@...o.com,
        robh@...nel.org, stefank@...dia.com, pdeschrijver@...dia.com,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/6] soc/tegra: fuse: Refactor resource mapping

On Thu, Sep 07, 2023 at 12:40:47PM +0530, Kartik wrote:
> To prepare for adding ACPI support to the tegra-apbmisc driver,
> relocate the code responsible for mapping memory resources from
> the function ‘tegra_init_apbmisc’ to the function
> ‘tegra_init_apbmisc_resources.’ This adjustment will allow the
> code to be shared between ‘tegra_init_apbmisc’ and the upcoming
> ‘tegra_acpi_init_apbmisc’ function.

...

> -void __init tegra_init_apbmisc(void)
> +static void tegra_init_apbmisc_resources(struct resource *apbmisc,
> +					 struct resource *straps)
>  {

> +}
> +
> +void __init tegra_init_apbmisc(void)

Looks like the patches can be improved by using --patience when you format
patches before sending.

-- 
With Best Regards,
Andy Shevchenko