linux-kernel - Re: [PATCH net v2 2/2] iavf: schedule a request immediately after add/delete vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230907153156.GJ434333@kernel.org>
Date:   Thu, 7 Sep 2023 17:31:56 +0200
From:   Simon Horman <horms@...nel.org>
To:     Petr Oros <poros@...hat.com>
Cc:     netdev@...r.kernel.org, jesse.brandeburg@...el.com,
        anthony.l.nguyen@...el.com, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        intel-wired-lan@...ts.osuosl.org, linux-kernel@...r.kernel.org,
        mschmidt@...hat.com, ivecera@...hat.com, ahmed.zaki@...el.com
Subject: Re: [PATCH net v2 2/2] iavf: schedule a request immediately after
 add/delete vlan

On Thu, Sep 07, 2023 at 05:02:51PM +0200, Petr Oros wrote:
> When the iavf driver wants to reconfigure the VLAN filters
> (iavf_add_vlan, iavf_del_vlan), it sets a flag in
> aq_required:
>   adapter->aq_required |= IAVF_FLAG_AQ_ADD_VLAN_FILTER;
> or:
>   adapter->aq_required |= IAVF_FLAG_AQ_DEL_VLAN_FILTER;
> 
> This is later processed by the watchdog_task, but it runs periodically
> every 2 seconds, so it can be a long time before it processes the request.
> 
> In the worst case, the interface is unable to receive traffic for more
> than 2 seconds for no objective reason.
> 
> Signed-off-by: Petr Oros <poros@...hat.com>
> Co-developed-by: Michal Schmidt <mschmidt@...hat.com>
> Signed-off-by: Michal Schmidt <mschmidt@...hat.com>
> Co-developed-by: Ivan Vecera <ivecera@...hat.com>
> Signed-off-by: Ivan Vecera <ivecera@...hat.com>
> Reviewed-by: Ahmed Zaki <ahmed.zaki@...el.com>

Reviewed-by: Simon Horman <horms@...nel.org>