[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9a84e07a-d74b-aa8c-3da2-a8fa0838a11e@intel.com>
Date: Fri, 8 Sep 2023 13:10:32 -0700
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: Petr Oros <poros@...hat.com>, <netdev@...r.kernel.org>
CC: <jesse.brandeburg@...el.com>, <davem@...emloft.net>,
<edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
<intel-wired-lan@...ts.osuosl.org>, <linux-kernel@...r.kernel.org>,
<mschmidt@...hat.com>, <ivecera@...hat.com>,
<ahmed.zaki@...el.com>, <horms@...nel.org>
Subject: Re: [PATCH net v2 2/2] iavf: schedule a request immediately after
add/delete vlan
On 9/7/2023 8:02 AM, Petr Oros wrote:
> When the iavf driver wants to reconfigure the VLAN filters
> (iavf_add_vlan, iavf_del_vlan), it sets a flag in
> aq_required:
> adapter->aq_required |= IAVF_FLAG_AQ_ADD_VLAN_FILTER;
> or:
> adapter->aq_required |= IAVF_FLAG_AQ_DEL_VLAN_FILTER;
>
> This is later processed by the watchdog_task, but it runs periodically
> every 2 seconds, so it can be a long time before it processes the request.
>
> In the worst case, the interface is unable to receive traffic for more
> than 2 seconds for no objective reason.
>
Changes look ok, however, can you supply or add a Fixes:?
> Signed-off-by: Petr Oros <poros@...hat.com>
> Co-developed-by: Michal Schmidt <mschmidt@...hat.com>
> Signed-off-by: Michal Schmidt <mschmidt@...hat.com>
> Co-developed-by: Ivan Vecera <ivecera@...hat.com>
> Signed-off-by: Ivan Vecera <ivecera@...hat.com>
> Reviewed-by: Ahmed Zaki <ahmed.zaki@...el.com>
> ---
> drivers/net/ethernet/intel/iavf/iavf_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
> index 86d472dfdbc10c..d9f8ac1d57fd62 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
> @@ -821,7 +821,7 @@ iavf_vlan_filter *iavf_add_vlan(struct iavf_adapter *adapter,
> list_add_tail(&f->list, &adapter->vlan_filter_list);
> f->state = IAVF_VLAN_ADD;
> adapter->num_vlan_filters++;
> - adapter->aq_required |= IAVF_FLAG_AQ_ADD_VLAN_FILTER;
> + iavf_schedule_aq_request(adapter, IAVF_FLAG_AQ_ADD_VLAN_FILTER);
> }
>
> clearout:
> @@ -843,7 +843,7 @@ static void iavf_del_vlan(struct iavf_adapter *adapter, struct iavf_vlan vlan)
> f = iavf_find_vlan(adapter, vlan);
> if (f) {
> f->state = IAVF_VLAN_REMOVE;
> - adapter->aq_required |= IAVF_FLAG_AQ_DEL_VLAN_FILTER;
> + iavf_schedule_aq_request(adapter, IAVF_FLAG_AQ_DEL_VLAN_FILTER);
> }
>
> spin_unlock_bh(&adapter->mac_vlan_list_lock);
Powered by blists - more mailing lists