linux-kernel - Re: [PATCH v3 4/5] drm/vc4: add trailing newlines to drm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <040b316aae533abac3d3fa9c1eaff3d1.mripard@kernel.org>
Date:   Thu, 07 Sep 2023 06:51:59 +0000
From:   "Maxime Ripard" <mripard@...nel.org>
To:     "Jim Cromie" <jim.cromie@...il.com>
Cc:     amd-gfx@...ts.freedesktop.org, daniel.vetter@...ll.ch,
        daniel@...ll.ch, dri-devel@...ts.freedesktop.org,
        intel-gfx@...ts.freedesktop.org,
        intel-gvt-dev@...ts.freedesktop.org, jani.nikula@...el.com,
        linux-kernel@...r.kernel.org, robdclark@...il.com,
        seanpaul@...omium.org, ville.syrjala@...ux.intel.com,
        "David Airlie" <airlied@...il.com>,
        "Emma Anholt" <emma@...olt.net>,
        "Maxime Ripard" <mripard@...nel.org>
Subject: Re: [PATCH v3 4/5] drm/vc4: add trailing newlines to drm_dbg msgs

On Wed, 6 Sep 2023 13:02:22 -0600, Jim Cromie wrote:
> By at least strong convention, a print-buffer's trailing newline says
> "message complete, send it".  The exception (no TNL, followed by a call
> to pr_cont) proves the general rule.
> 
> Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG,
> 
> [ ... ]

Acked-by: Maxime Ripard <mripard@...nel.org>

Thanks!
Maxime