[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <p3pmpj6a72tinjalmntxjw4cqhltkqux2zjwgwx4sxvvqeitkp@6wqr7aujr4h6>
Date: Thu, 7 Sep 2023 08:51:44 +0200
From: Maxime Ripard <mripard@...nel.org>
To: Jim Cromie <jim.cromie@...il.com>
Cc: linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
amd-gfx@...ts.freedesktop.org, intel-gvt-dev@...ts.freedesktop.org,
intel-gfx@...ts.freedesktop.org, daniel.vetter@...ll.ch,
daniel@...ll.ch, jani.nikula@...el.com,
ville.syrjala@...ux.intel.com, seanpaul@...omium.org,
robdclark@...il.com,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>
Subject: Re: [PATCH v3 1/5] drm/connector: add trailing newlines to drm_dbg
msgs
On Wed, Sep 06, 2023 at 01:02:19PM -0600, Jim Cromie wrote:
> By at least strong convention, a print-buffer's trailing newline says
> "message complete, send it". The exception (no TNL, followed by a call
> to pr_cont) proves the general rule.
>
> Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG,
> 1288 drm_dbg. Clean up the remainders, in maintainer sized chunks.
>
> No functional changes.
>
> Signed-off-by: Jim Cromie <jim.cromie@...il.com>
> ---
> drivers/gpu/drm/drm_connector.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
> index f28725736237..14020585bdc0 100644
> --- a/drivers/gpu/drm/drm_connector.c
> +++ b/drivers/gpu/drm/drm_connector.c
> @@ -2925,7 +2925,9 @@ int drm_mode_getconnector(struct drm_device *dev, void *data,
> dev->mode_config.max_width,
> dev->mode_config.max_height);
> else
> - drm_dbg_kms(dev, "User-space requested a forced probe on [CONNECTOR:%d:%s] but is not the DRM master, demoting to read-only probe",
> + drm_dbg_kms(dev,
> + "User-space requested a forced probe on [CONNECTOR:%d:%s] "
> + "but is not the DRM master, demoting to read-only probe\n",
> connector->base.id, connector->name);
I'm fine with the general idea behind this patch, but we shouldn't break
the message itself.
See https://www.kernel.org/doc/html/latest/process/coding-style.html#breaking-long-lines-and-strings
Maxime
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists