linux-kernel - [PATCH] wifi: rtw88: rtw8723d: Fix MAC address offset in EEPROM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20230907080942.2111305-1-s.hauer@pengutronix.de>
Date:   Thu,  7 Sep 2023 10:09:42 +0200
From:   Sascha Hauer <s.hauer@...gutronix.de>
To:     linux-wireless@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Kalle Valo <kvalo@...nel.org>,
        Ping-Ke Shih <pkshih@...ltek.com>,
        Yanik Fuchs <Yanik.fuchs@....ch>,
        Sascha Hauer <s.hauer@...gutronix.de>, stable@...r.kernel.org
Subject: [PATCH] wifi: rtw88: rtw8723d: Fix MAC address offset in EEPROM

The MAC address is stored at offset 0x107 in the EEPROM, like correctly
stated in the comment. Add a two bytes reserved field right before the
MAC address to shift it from offset 0x105 to 0x107.

With this the MAC address returned from my RTL8723du wifi stick can be
correctly decoded as "Shenzhen Four Seas Global Link Network Technology
Co., Ltd."

Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>
Reported-by: Yanik Fuchs <Yanik.fuchs@....ch>
Cc: stable@...r.kernel.org
---
 drivers/net/wireless/realtek/rtw88/rtw8723d.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/realtek/rtw88/rtw8723d.h b/drivers/net/wireless/realtek/rtw88/rtw8723d.h
index 3642a2c7f80c9..2434e2480cbe2 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8723d.h
+++ b/drivers/net/wireless/realtek/rtw88/rtw8723d.h
@@ -46,6 +46,7 @@ struct rtw8723du_efuse {
 	u8 vender_id[2];                /* 0x100 */
 	u8 product_id[2];               /* 0x102 */
 	u8 usb_option;                  /* 0x104 */
+	u8 res5[2];			/* 0x105 */
 	u8 mac_addr[ETH_ALEN];          /* 0x107 */
 };
 
-- 
2.39.2