linux-kernel - Re: [PATCH 22/52] m68k: atari: Add and use "atari.h"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 8 Sep 2023 12:46:11 +1200
From:   Michael Schmitz <schmitzmic@...il.com>
To:     Finn Thain <fthain@...ux-m68k.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     linux-m68k@...ts.linux-m68k.org, Arnd Bergmann <arnd@...db.de>,
        Philip Blundell <philb@....org>,
        Greg Ungerer <gerg@...ux-m68k.org>,
        Joshua Thompson <funaho@...ai.org>,
        Sam Creasey <sammy@...my.net>,
        Laurent Vivier <laurent@...ier.eu>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 22/52] m68k: atari: Add and use "atari.h"

Hi Finn,

On 8/09/23 11:57, Finn Thain wrote:
> On Thu, 7 Sep 2023, Geert Uytterhoeven wrote:
>
>> diff --git a/arch/m68k/atari/atari.h b/arch/m68k/atari/atari.h
>> new file mode 100644
>> index 0000000000000000..494a03ddac3d16ae
>> --- /dev/null
>> +++ b/arch/m68k/atari/atari.h
>> @@ -0,0 +1,15 @@
>> +/* SPDX-License-Identifier: GPL-2.0-only */
>> +
>> +struct rtc_time;
>> +
>> +/* ataints.c */
>> +void atari_init_IRQ(void);
>> +
>> +/* atasound.c */
>> +void atari_microwire_cmd(int cmd);
>> +void atari_mksound(unsigned int hz, unsigned int ticks);
>> +
>> +/* time.c */
>> +void atari_sched_init(void);
>> +int atari_mste_hwclk(int op, struct rtc_time *t);
>> +int atari_tt_hwclk(int op, struct rtc_time *t);
> Wouldn't atariints.h and atarihw.h be more appropriate places for some of
> these?

atariints.h already has some prototypes, so yes on that account.

atarihw.h only has inlines, but sound and time related prototypes could 
be added there, too.

Geert's intentions might have been avoiding inclusion of all the 
hardware specific data in those two files, but the only source file to 
benefit from this is config.c (the other three already include 
atariints.h and atarihw.h).

OTOH, considering this patch series adds a lot of other headers that 
only contain prototypes, it might be better to keep to that pattern 
everywhere.

Cheers,

     Michael