linux-kernel - Re: [PATCH 22/52] m68k: atari: Add and use "atari.h"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <291d4cb0-e3b8-1e7d-8b34-79aee23865fa@linux-m68k.org>
Date:   Fri, 8 Sep 2023 11:05:59 +1000 (AEST)
From:   Finn Thain <fthain@...ux-m68k.org>
To:     Michael Schmitz <schmitzmic@...il.com>
cc:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        linux-m68k@...ts.linux-m68k.org, Arnd Bergmann <arnd@...db.de>,
        Philip Blundell <philb@....org>,
        Greg Ungerer <gerg@...ux-m68k.org>,
        Joshua Thompson <funaho@...ai.org>,
        Sam Creasey <sammy@...my.net>,
        Laurent Vivier <laurent@...ier.eu>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 22/52] m68k: atari: Add and use "atari.h"

On Fri, 8 Sep 2023, Michael Schmitz wrote:

> 
> atariints.h already has some prototypes, so yes on that account.
> 
> atarihw.h only has inlines, but sound and time related prototypes could 
> be added there, too.
> 
> Geert's intentions might have been avoiding inclusion of all the 
> hardware specific data in those two files, but the only source file to 
> benefit from this is config.c (the other three already include 
> atariints.h and atarihw.h).
> 
> OTOH, considering this patch series adds a lot of other headers that 
> only contain prototypes, it might be better to keep to that pattern 
> everywhere.
> 

I think Geert's intention may have been to avoid adding definitions to the 
asm/foo.h headers shipped with "make headers_install". If that's the 
intention, there would seem to be a mess to be cleaned up, for which I'm 
partly to blame...