linux-kernel - Re: [PATCH v2] mtd: nand: qcom: Fix the node for nand unmap resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230911174039.63f6e835@xps-13>
Date:   Mon, 11 Sep 2023 17:40:39 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Bibek Kumar Patro <quic_bibekkum@...cinc.com>
Cc:     <mani@...nel.org>, <richard@....at>, <vigneshr@...com>,
        <linux-mtd@...ts.infradead.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <kernel@...cinc.com>,
        <quic_charnte@...cinc.com>, <quic_kaushalk@...cinc.com>,
        <quic_pkondeti@...cinc.com>
Subject: Re: [PATCH v2] mtd: nand: qcom: Fix the node for nand unmap
 resource

Hi Bibek,

quic_bibekkum@...cinc.com wrote on Mon, 11 Sep 2023 19:00:26 +0530:

The title prefix should be s/nand/rawnand.

The title itself is unclear "fix the node" does not mean anything to me.

> Fix addr argument to dma_unmap_resource() in the error path of probe.

      ^
No abbreviation unless you are quoting the code directly.

                    of?                            probe error path

> The addr argument should be dma address instead of physical address.
      ^                      ^                      ^
      ditto                  the?                   the?

> 
> Fixes: 7330fc505af4 ("mtd: rawnand: qcom: stop using phys_to_dma()")
> Signed-off-by: Bibek Kumar Patro <quic_bibekkum@...cinc.com>
> ---
> v2: Incorporated comments from Pavan/Mani.
> 
> v1: https://lore.kernel.org/all/20230907092854.11408-1-quic_bibekkum@quicinc.com/
> 
>  drivers/mtd/nand/raw/qcom_nandc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c
> index 64499c1b3603..b079605c84d3 100644
> --- a/drivers/mtd/nand/raw/qcom_nandc.c
> +++ b/drivers/mtd/nand/raw/qcom_nandc.c
> @@ -3444,7 +3444,7 @@ static int qcom_nandc_probe(struct platform_device *pdev)
>  err_aon_clk:
>  	clk_disable_unprepare(nandc->core_clk);
>  err_core_clk:
> -	dma_unmap_resource(dev, res->start, resource_size(res),
> +	dma_unmap_resource(dev, nandc->base_dma, resource_size(res),
>  			   DMA_BIDIRECTIONAL, 0);
>  	return ret;
>  }
> --
> 2.17.1
> 


Thanks,
Miquèl