linux-kernel - Re: [PATCH v2] mtd: nand: qcom: Fix the node for nand unmap resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f3d77752-f5f0-4896-b209-8e02f501a5b1@quicinc.com>
Date:   Tue, 12 Sep 2023 01:30:16 +0530
From:   Bibek Kumar Patro <quic_bibekkum@...cinc.com>
To:     Miquel Raynal <miquel.raynal@...tlin.com>
CC:     <mani@...nel.org>, <richard@....at>, <vigneshr@...com>,
        <linux-mtd@...ts.infradead.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <kernel@...cinc.com>,
        <quic_charnte@...cinc.com>, <quic_kaushalk@...cinc.com>,
        <quic_pkondeti@...cinc.com>
Subject: Re: [PATCH v2] mtd: nand: qcom: Fix the node for nand unmap resource



On 9/11/2023 9:10 PM, Miquel Raynal wrote:
> Hi Bibek,
> 
> quic_bibekkum@...cinc.com wrote on Mon, 11 Sep 2023 19:00:26 +0530:
> 
> The title prefix should be s/nand/rawnand.
> 
> The title itself is unclear "fix the node" does not mean anything to me.
> 

sure Miquel, will rectify the prefix and give a meaningful title in the
next patch.

>> Fix addr argument to dma_unmap_resource() in the error path of probe.
> 
>        ^
> No abbreviation unless you are quoting the code directly.
> 
>                      of?                            probe error path
> 
>> The addr argument should be dma address instead of physical address.
>        ^                      ^                      ^
>        ditto                  the?                   the?
> 

Thanks for these pointers, will revise the commit message removing
abbreviations and making other changes as suggested.

Thanks,
Bibek

>>
>> Fixes: 7330fc505af4 ("mtd: rawnand: qcom: stop using phys_to_dma()")
>> Signed-off-by: Bibek Kumar Patro <quic_bibekkum@...cinc.com>
>> ---
>> v2: Incorporated comments from Pavan/Mani.
>>
>> v1: https://lore.kernel.org/all/20230907092854.11408-1-quic_bibekkum@quicinc.com/
>>
>>   drivers/mtd/nand/raw/qcom_nandc.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c
>> index 64499c1b3603..b079605c84d3 100644
>> --- a/drivers/mtd/nand/raw/qcom_nandc.c
>> +++ b/drivers/mtd/nand/raw/qcom_nandc.c
>> @@ -3444,7 +3444,7 @@ static int qcom_nandc_probe(struct platform_device *pdev)
>>   err_aon_clk:
>>   	clk_disable_unprepare(nandc->core_clk);
>>   err_core_clk:
>> -	dma_unmap_resource(dev, res->start, resource_size(res),
>> +	dma_unmap_resource(dev, nandc->base_dma, resource_size(res),
>>   			   DMA_BIDIRECTIONAL, 0);
>>   	return ret;
>>   }
>> --
>> 2.17.1
>>
> 
> 
> Thanks,
> Miquèl