linux-kernel - Re: [PATCH RESEND v3 2/2] selftests/resctrl: Move run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e0fa9375-0b50-af89-81d3-eaaecf19a788@intel.com>
Date:   Mon, 11 Sep 2023 09:59:31 -0700
From:   Reinette Chatre <reinette.chatre@...el.com>
To:     Wieczor-Retman Maciej <maciej.wieczor-retman@...el.com>,
        Fenghua Yu <fenghua.yu@...el.com>,
        Shuah Khan <shuah@...nel.org>
CC:     <ilpo.jarvinen@...ux.intel.com>, <linux-kernel@...r.kernel.org>,
        <linux-kselftest@...r.kernel.org>
Subject: Re: [PATCH RESEND v3 2/2] selftests/resctrl: Move run_benchmark() to
 a more fitting file

Hi Maciej,

On 9/1/2023 6:42 AM, Wieczor-Retman Maciej wrote:
> resctrlfs.c file contains mostly functions that interact in some way

This can just be "resctrlfs.c contains ..." (no need for "file")

> with resctrl FS entries while functions inside resctrl_val.c deal with
> measurements and benchmarking.
> 
> run_benchmark() is located in resctrlfs.c file even though it's

same here

> purpose is not interacting with the resctrl FS but to execute cache
> checking logic.
> 
> Move run_benchmark() to resctrl_val.c just before resctrl_val() that
> makes use of run_benchmark(). Make run_benchmark() static since it's
> not used between multiple files anymore.
> 
> Remove return comment from kernel-doc since the function is type void.
> 
> Signed-off-by: Wieczor-Retman Maciej <maciej.wieczor-retman@...el.com>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>

Reinette