[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8734zk1v3n.fsf@oracle.com>
Date: Mon, 11 Sep 2023 10:24:28 -0700
From: Ankur Arora <ankur.a.arora@...cle.com>
To: Peter Zijlstra <peterz@...radead.org>
Cc: Ankur Arora <ankur.a.arora@...cle.com>,
linux-kernel@...r.kernel.org, linux-mm@...ck.org, x86@...nel.org,
akpm@...ux-foundation.org, luto@...nel.org, bp@...en8.de,
dave.hansen@...ux.intel.com, hpa@...or.com, mingo@...hat.com,
juri.lelli@...hat.com, vincent.guittot@...aro.org,
willy@...radead.org, mgorman@...e.de, rostedt@...dmis.org,
tglx@...utronix.de, jon.grimm@....com, bharata@....com,
raghavendra.kt@....com, boris.ostrovsky@...cle.com,
konrad.wilk@...cle.com
Subject: Re: [PATCH v2 8/9] irqentry: define irqentry_exit_allow_resched()
Peter Zijlstra <peterz@...radead.org> writes:
> On Wed, Aug 30, 2023 at 11:49:57AM -0700, Ankur Arora wrote:
>
>> +#ifdef TIF_RESCHED_ALLOW
>> +#define irqentry_exit_cond_resched_dynamic_disabled irqentry_exit_allow_resched
>> +#else
>> #define irqentry_exit_cond_resched_dynamic_disabled NULL
>> +#endif
>
> per ^, the below comments are not entirely accurate, since not every
> architecture has TIF_RESCHED_ALLOW, perhaps make it:
>
>> @@ -8692,25 +8694,25 @@ EXPORT_SYMBOL(__cond_resched_rwlock_write);
>> *
>> *
>> * NONE:
>> - * cond_resched <- __cond_resched
>> - * might_resched <- RET0
>> - * preempt_schedule <- NOP
>> - * preempt_schedule_notrace <- NOP
>> - * irqentry_exit_cond_resched <- NOP
>> + * cond_resched <- __cond_resched
>> + * might_resched <- RET0
>> + * preempt_schedule <- NOP
>> + * preempt_schedule_notrace <- NOP
>> + * irqentry_exit_cond_resched <- irqentry_exit_allow_resched
>
> + * irqentry_exit_cond_resched <- NOP / irqentry_exit_allow_resched
>
> Or something.
>
> Also, why did you add that extra whilespace all over? Makes it a bit
> harder to see what actually changed.
Yeah, not sure why I didn't catch that. Will fix.
--
ankur
Powered by blists - more mailing lists