linux-kernel - Re: [PATCH 1/3] dt-bindings: interconnect: Add Qualcomm SM4450

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5f172a8f-ecd7-44b0-9b02-48eb13d40497@quicinc.com>
Date:   Mon, 11 Sep 2023 18:15:44 +0800
From:   Tengfei Fan <quic_tengfan@...cinc.com>
To:     Rob Herring <robh@...nel.org>
CC:     <will@...nel.org>, <arnd@...db.de>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <quic_kaushalk@...cinc.com>,
        <peng.fan@....com>, <kernel@...cinc.com>,
        <catalin.marinas@....com>, <rafal@...ecki.pl>,
        <krzysztof.kozlowski+dt@...aro.org>, <nfraprado@...labora.com>,
        <quic_shashim@...cinc.com>, <robh+dt@...nel.org>,
        <linux-arm-msm@...r.kernel.org>, <quic_tingweiz@...cinc.com>,
        <quic_aiquny@...cinc.com>, <linux-pm@...r.kernel.org>,
        <quic_tsoni@...cinc.com>, <geert+renesas@...der.be>,
        <andersson@...nel.org>, <conor+dt@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <agross@...nel.org>,
        <quic_tdas@...cinc.com>, <djakov@...nel.org>,
        <konrad.dybcio@...aro.org>
Subject: Re: [PATCH 1/3] dt-bindings: interconnect: Add Qualcomm SM4450



在 9/8/2023 4:25 PM, Tengfei Fan 写道:
> 
> 
> 在 9/8/2023 3:42 PM, Rob Herring 写道:
>>
>> On Fri, 08 Sep 2023 14:44:25 +0800, Tengfei Fan wrote:
>>> The Qualcomm SM4450 SoC has several bus fabrics that could be controlled
>>> and tuned dynamically according to the bandwidth demand.
>>>
>>> Signed-off-by: Tengfei Fan <quic_tengfan@...cinc.com>
>>> ---
>>>   .../interconnect/qcom,sm4450-rpmh.yaml        | 133 ++++++++++++++
>>>   .../dt-bindings/interconnect/qcom,sm4450.h    | 163 ++++++++++++++++++
>>>   2 files changed, 296 insertions(+)
>>>   create mode 100644 
>>> Documentation/devicetree/bindings/interconnect/qcom,sm4450-rpmh.yaml
>>>   create mode 100644 include/dt-bindings/interconnect/qcom,sm4450.h
>>>
>>
>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> Documentation/devicetree/bindings/interconnect/qcom,sm4450-rpmh.example.dts:18:18: fatal error: dt-bindings/clock/qcom,gcc-sm4450.h: No such file or directory
>>     18 |         #include <dt-bindings/clock/qcom,gcc-sm4450.h>
>>        |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> compilation terminated.
>> make[2]: *** [scripts/Makefile.lib:419: 
>> Documentation/devicetree/bindings/interconnect/qcom,sm4450-rpmh.example.dtb] Error 1
>> make[2]: *** Waiting for unfinished jobs....
>> make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1500: 
>> dt_binding_check] Error 2
>> make: *** [Makefile:234: __sub-make] Error 2
>>
>> doc reference errors (make refcheckdocs):
>>
>> See 
>> https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230908064427.26999-2-quic_tengfan@quicinc.com
>>
>> The base for the series is generally the latest rc1. A different 
>> dependency
>> should be noted in *this* patch.
>>
>> If you already ran 'make dt_binding_check' and didn't see the above
>> error(s), then make sure 'yamllint' is installed and dt-schema is up to
>> date:
>>
>> pip3 install dtschema --upgrade
>>
>> Please check and re-submit after running the above command yourself. Note
>> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
>> your schema. However, it must be unset to test all examples with your 
>> schema.
>>
> Thanks review this patch, will setup new env for verify again.
> 
this error is due to have dependence with: 
https://lore.kernel.org/linux-arm-msm/20230824173410.550126-1-quic_ajipan@quicinc.com/, 
will add this link to coverletter.

-- 
Thx and BRs,
Tengfei Fan