linux-kernel - Re: [PATCH] arm64: dts: ti: k3-j721s2-evm-gesi: Specify base dtb for overlay file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230911165610.GA1362932-robh@kernel.org>
Date:   Mon, 11 Sep 2023 11:56:10 -0500
From:   Rob Herring <robh@...nel.org>
To:     Siddharth Vadapalli <s-vadapalli@...com>
Cc:     nm@...com, vigneshr@...com, kristo@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, r-gunasekaran@...com,
        srk@...com
Subject: Re: [PATCH] arm64: dts: ti: k3-j721s2-evm-gesi: Specify base dtb for
 overlay file

On Mon, Sep 11, 2023 at 10:51:58AM +0530, Siddharth Vadapalli wrote:
> Specify the base dtb file k3-j721s2-common-proc-board.dtb on which the
> k3-j721s2-evm-gesi-exp-board.dtbo overlay has to be applied. Name the
> resulting dtb as k3-j721s2-evm.dtb.
> 
> Fixes: cac04e27f093 ("arm64: dts: ti: k3-j721s2: Add overlay to enable main CPSW2G with GESI")
> Reported-by: Rob Herring <robh+dt@...nel.org>
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@...com>
> ---
> 
> Note: This patch is based on linux-next tagged next-20230911.
> 
>  arch/arm64/boot/dts/ti/Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile
> index e7b8e2e7f083..ef8ca50fbb36 100644
> --- a/arch/arm64/boot/dts/ti/Makefile
> +++ b/arch/arm64/boot/dts/ti/Makefile
> @@ -63,9 +63,9 @@ dtb-$(CONFIG_ARCH_K3) += k3-j721e-evm-gesi-exp-board.dtbo
>  dtb-$(CONFIG_ARCH_K3) += k3-j721e-sk.dtb
>  
>  # Boards with J721s2 SoC
> +k3-j721s2-evm-dtbs := k3-j721s2-common-proc-board.dtb k3-j721s2-evm-gesi-exp-board.dtbo

Move this next to the "dtb-$(CONFIG_ARCH_K3) += k3-j721s2-evm.dtb" line.

>  dtb-$(CONFIG_ARCH_K3) += k3-am68-sk-base-board.dtb
> -dtb-$(CONFIG_ARCH_K3) += k3-j721s2-common-proc-board.dtb
> -dtb-$(CONFIG_ARCH_K3) += k3-j721s2-evm-gesi-exp-board.dtbo

I think dropping these will cause them to not get installed (by 
dtbs_install). Presumably you want them.

> +dtb-$(CONFIG_ARCH_K3) += k3-j721s2-evm.dtb
>  
>  # Boards with J784s4 SoC
>  dtb-$(CONFIG_ARCH_K3) += k3-am69-sk.dtb
> -- 
> 2.34.1
>