linux-kernel - Re: [PATCH] arm64: dts: ti: k3-j721s2-evm-gesi: Specify base dtb for overlay file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <340bb897-d735-fabc-a031-8e4ebcfe79fa@ti.com>
Date:   Tue, 12 Sep 2023 09:31:17 +0530
From:   Siddharth Vadapalli <s-vadapalli@...com>
To:     Rob Herring <robh@...nel.org>
CC:     <nm@...com>, <vigneshr@...com>, <kristo@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <r-gunasekaran@...com>,
        <srk@...com>, <s-vadapalli@...com>
Subject: Re: [PATCH] arm64: dts: ti: k3-j721s2-evm-gesi: Specify base dtb for
 overlay file

Rob,

Thank you for reviewing the patch.

On 11/09/23 22:26, Rob Herring wrote:
> On Mon, Sep 11, 2023 at 10:51:58AM +0530, Siddharth Vadapalli wrote:
>> Specify the base dtb file k3-j721s2-common-proc-board.dtb on which the
>> k3-j721s2-evm-gesi-exp-board.dtbo overlay has to be applied. Name the
>> resulting dtb as k3-j721s2-evm.dtb.
>>
>> Fixes: cac04e27f093 ("arm64: dts: ti: k3-j721s2: Add overlay to enable main CPSW2G with GESI")
>> Reported-by: Rob Herring <robh+dt@...nel.org>
>> Signed-off-by: Siddharth Vadapalli <s-vadapalli@...com>
>> ---
>>
>> Note: This patch is based on linux-next tagged next-20230911.
>>
>>  arch/arm64/boot/dts/ti/Makefile | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile
>> index e7b8e2e7f083..ef8ca50fbb36 100644
>> --- a/arch/arm64/boot/dts/ti/Makefile
>> +++ b/arch/arm64/boot/dts/ti/Makefile
>> @@ -63,9 +63,9 @@ dtb-$(CONFIG_ARCH_K3) += k3-j721e-evm-gesi-exp-board.dtbo
>>  dtb-$(CONFIG_ARCH_K3) += k3-j721e-sk.dtb
>>  
>>  # Boards with J721s2 SoC
>> +k3-j721s2-evm-dtbs := k3-j721s2-common-proc-board.dtb k3-j721s2-evm-gesi-exp-board.dtbo
> 
> Move this next to the "dtb-$(CONFIG_ARCH_K3) += k3-j721s2-evm.dtb" line.

Sure, I will place it above the k3-j721s2-evm.dtb line.

> 
>>  dtb-$(CONFIG_ARCH_K3) += k3-am68-sk-base-board.dtb
>> -dtb-$(CONFIG_ARCH_K3) += k3-j721s2-common-proc-board.dtb
>> -dtb-$(CONFIG_ARCH_K3) += k3-j721s2-evm-gesi-exp-board.dtbo
> 
> I think dropping these will cause them to not get installed (by 
> dtbs_install). Presumably you want them.

I will undo the above deletions in the v2 patch.

> 
>> +dtb-$(CONFIG_ARCH_K3) += k3-j721s2-evm.dtb
>>  
>>  # Boards with J784s4 SoC
>>  dtb-$(CONFIG_ARCH_K3) += k3-am69-sk.dtb
>> -- 
>> 2.34.1
>>

-- 
Regards,
Siddharth.