linux-kernel - Re: [RFT PATCH 2/3] gpio: eic-sprd: use a helper variable for &pdev->dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=McVgkt+BQ33dYE0V3-dWcJbNHALaE4-Ao02Y7jh=P=0rg@mail.gmail.com>
Date:   Tue, 12 Sep 2023 13:23:49 +0200
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Andy Shevchenko <andy@...nel.org>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Orson Zhai <orsonzhai@...il.com>,
        Baolin Wang <baolin.wang@...ux.alibaba.com>,
        Chunyan Zhang <zhang.lyra@...il.com>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [RFT PATCH 2/3] gpio: eic-sprd: use a helper variable for &pdev->dev

On Tue, Sep 12, 2023 at 12:35 PM Andy Shevchenko <andy@...nel.org> wrote:
>
> On Tue, Sep 12, 2023 at 11:45:18AM +0200, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> >
> > Instead of dereferencing pdev everywhere, just store the address of the
> > underlying struct device in a local variable.
>
> ...
>
> > -     return devm_add_action_or_reset(&pdev->dev,
> > -                                     sprd_eic_unregister_notifier,
> > +     return devm_add_action_or_reset(dev, sprd_eic_unregister_notifier,
> >                                       &sprd_eic->irq_nb);
>
> Ping-pong style detected: Lines added / modified by previous patch in the same
> series got modified again.
>
> If you look at how I do that, I introduce the temporary variable with my new
> code and then reuse it later on.
>
> OTOH, I see that the first one is supposed to be backported (?) in such case
> perhaps it's fine.

I would typically do the same but the fix comes first in series.

Bart