linux-kernel - Re: [PATCH v2 09/11] gpio: acpi: replace gpiochip_find() with gpio_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZQBMBubLx2zSYwqL@smile.fi.intel.com>
Date:   Tue, 12 Sep 2023 14:31:18 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-acpi@...r.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH v2 09/11] gpio: acpi: replace gpiochip_find() with
 gpio_device_find()

On Tue, Sep 12, 2023 at 12:07:25PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> 
> We're porting all users of gpiochip_find() to using gpio_device_find().
> Update the ACPI GPIO code.

...

> +	/*
> +	 * FIXME: keep track of this reference somehow instead of putting it
> +	 * here.

Under "this" you meant gdev? Please, spell it explicitly, I spent a couple of
minutes to get what exactly this comment is about.

> +	 */
> +	return gpio_device_get_desc(gdev, pin);
>  }

-- 
With Best Regards,
Andy Shevchenko