linux-kernel - Re: [PATCH] usb: xhci: xhci-ring: Use sysdev for mapping bounce buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7c388791-e4cd-28da-3d98-5cc233bec165@linux.intel.com>
Date:   Tue, 12 Sep 2023 14:33:20 +0300
From:   Mathias Nyman <mathias.nyman@...ux.intel.com>
To:     Wesley Cheng <quic_wcheng@...cinc.com>, mathias.nyman@...el.com,
        gregkh@...uxfoundation.org
Cc:     linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
        quic_jackp@...cinc.com, stable@...r.kernel.org
Subject: Re: [PATCH] usb: xhci: xhci-ring: Use sysdev for mapping bounce
 buffer

On 12.9.2023 2.41, Wesley Cheng wrote:
> As mentioned in:
>    commit 474ed23a6257 ("xhci: align the last trb before link if it is
> easily splittable.")
> 
> A bounce buffer is utilized for ensuring that transfers that span across
> ring segments are aligned to the EP's max packet size.  However, the device
> that is used to map the DMA buffer to is currently using the XHCI HCD,
> which does not carry any DMA operations in certain configrations.
> Migration to using the sysdev entry was introduced for DWC3 based
> implementations where the IOMMU operations are present.
> 
> Replace the reference to the controller device to sysdev instead.  This
> allows the bounce buffer to be properly mapped to any implementations that
> have an IOMMU involved.
> 
> cc: <stable@...r.kernel.org>
> Fixes: 4c39d4b949d3 ("usb: xhci: use bus->sysdev for DMA configuration")
> Signed-off-by: Wesley Cheng <quic_wcheng@...cinc.com>
> ---

Thanks, adding to queue

-Mathias