linux-kernel - Re: [PATCH v1 1/1] serial: 8250_bcm7271: Use dev_err_probe() instead of dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <412c5225-e9c0-6a8d-1b39-2ce60cbf8074@wanadoo.fr>
Date:   Tue, 12 Sep 2023 20:20:49 +0200
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Al Cooper <alcooperx@...il.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>,
        Jiri Slaby <jirislaby@...nel.org>
Subject: Re: [PATCH v1 1/1] serial: 8250_bcm7271: Use dev_err_probe() instead
 of dev_err()

Le 12/09/2023 à 18:55, Andy Shevchenko a écrit :
> Make the error messages format unified by switching to use
> dev_err_probe() where it makes sense.
> 
> This also helps simplifing the code.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>   drivers/tty/serial/8250/8250_bcm7271.c | 17 +++++++----------
>   1 file changed, 7 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_bcm7271.c b/drivers/tty/serial/8250/8250_bcm7271.c
> index aa5aff046756..51c3eca8673c 100644
> --- a/drivers/tty/serial/8250/8250_bcm7271.c
> +++ b/drivers/tty/serial/8250/8250_bcm7271.c
> @@ -984,10 +984,9 @@ static int brcmuart_probe(struct platform_device *pdev)
>   	}
>   
>   	/* We should have just the uart base registers or all the registers */
> -	if (x != 1 && x != REGS_MAX) {
> -		dev_warn(dev, "%s registers not specified\n", reg_names[x]);
> -		return -EINVAL;
> -	}
> +	if (x != 1 && x != REGS_MAX)
> +		return dev_err_probe(dev, -EINVAL, "%s registers not specified\n",
> +				     reg_names[x]);
>   
>   	/* if the DMA registers were specified, try to enable DMA */
>   	if (x > REGS_DMA_RX) {
> @@ -1034,8 +1033,7 @@ static int brcmuart_probe(struct platform_device *pdev)
>   	}
>   
>   	if (clk_rate == 0) {
> -		dev_err(dev, "clock-frequency or clk not defined\n");
> -		ret = -EINVAL;
> +		ret = dev_err_probe(dev, -EINVAL, "clock-frequency or clk not defined\n");
>   		goto err_clk_disable;
>   	}
>   
> @@ -1093,7 +1091,7 @@ static int brcmuart_probe(struct platform_device *pdev)
>   
>   	ret = serial8250_register_8250_port(&up);
>   	if (ret < 0) {
> -		dev_err(dev, "unable to register 8250 port\n");
> +		dev_err_probe(dev, ret, "unable to register 8250 port\n");
>   		goto err;
>   	}
>   	priv->line = ret;
> @@ -1102,14 +1100,13 @@ static int brcmuart_probe(struct platform_device *pdev)
>   	if (priv->dma_enabled) {
>   		dma_irq = platform_get_irq_byname(pdev,  "dma");
>   		if (dma_irq < 0) {
> -			ret = dma_irq;
> -			dev_err(dev, "no IRQ resource info\n");
> +			dev_err_probe(dev, dma_irq, "no IRQ resource info\n");

ret = dev_err_probe(dev, dma_irq, "no IRQ resource info\n");

>   			goto err1;
>   		}
>   		ret = devm_request_irq(dev, dma_irq, brcmuart_isr,
>   				IRQF_SHARED, "uart DMA irq", &new_port->port);
>   		if (ret) {
> -			dev_err(dev, "unable to register IRQ handler\n");
> +			dev_err_probe(dev, ret, "unable to register IRQ handler\n");
>   			goto err1;
>   		}
>   	}