linux-kernel - Re: [PATCH v1 1/1] serial: 8250_bcm7271: Use dev_err_probe() instead of dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZQGZItGcauus7l9F@smile.fi.intel.com>
Date:   Wed, 13 Sep 2023 14:12:34 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
        Al Cooper <alcooperx@...il.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>,
        Jiri Slaby <jirislaby@...nel.org>
Subject: Re: [PATCH v1 1/1] serial: 8250_bcm7271: Use dev_err_probe() instead
 of dev_err()

On Tue, Sep 12, 2023 at 08:20:49PM +0200, Christophe JAILLET wrote:
> Le 12/09/2023 à 18:55, Andy Shevchenko a écrit :

...

> > -			ret = dma_irq;
> > -			dev_err(dev, "no IRQ resource info\n");
> > +			dev_err_probe(dev, dma_irq, "no IRQ resource info\n");
> 
> ret = dev_err_probe(dev, dma_irq, "no IRQ resource info\n");

Good catch, thanks!

> >   			goto err1;
> >   		}

-- 
With Best Regards,
Andy Shevchenko