linux-kernel - Re: [PATCH 2/5] selftests/resctrl: Remove duplicate feature check from CMT test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <80695068-4a6-b8e9-107f-8d29ab3543be@linux.intel.com>
Date:   Wed, 13 Sep 2023 14:11:49 +0300 (EEST)
From:   Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To:     Reinette Chatre <reinette.chatre@...el.com>
cc:     Shuah Khan <shuah@...nel.org>,
        Shuah Khan <skhan@...uxfoundation.org>,
        linux-kselftest@...r.kernel.org,
        Maciej Wieczór-Retman 
        <maciej.wieczor-retman@...el.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Shaopeng Tan <tan.shaopeng@...fujitsu.com>,
        stable@...r.kernel.org
Subject: Re: [PATCH 2/5] selftests/resctrl: Remove duplicate feature check
 from CMT test

On Tue, 12 Sep 2023, Reinette Chatre wrote:
> On 9/11/2023 4:19 AM, Ilpo Järvinen wrote:
> > The test runner run_cmt_test() in resctrl_tests.c checks for CMT
> > feature and does not run cmt_resctrl_val() if CMT is not supported.
> > Then cmt_resctrl_val() also check is CMT is supported.
> > 
> > Remove the duplicated feature check for CMT from cmt_resctrl_val().
> > 
> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> > Cc: <stable@...r.kernel.org>
> 
> This does not look like stable material to me. 

I know but when constructing this series I had 2 options:

Either convert also this when changing validate_resctrl_feature_request() 
or remove this call entirely.

Given it's duplicate of the other CMT check, I chose to just remove it 
(which I'd do anyway). As patch 4/5 requires 3/5 which in turn requires 
this, this has to go stable if 4/5 goes too.

-- 
 i.