linux-kernel - Re: [net PATCH] octeon_ep: fix tx dma unmap len values in SG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2c532d4594ca0cacdc0cfc5d1f5d55d5d758dc1b.camel@redhat.com>
Date:   Tue, 12 Sep 2023 10:45:21 +0200
From:   Paolo Abeni <pabeni@...hat.com>
To:     Shinas Rasheed <srasheed@...vell.com>, horms@...nel.org
Cc:     aayarekar@...vell.com, davem@...emloft.net, edumazet@...gle.com,
        egallen@...hat.com, hgani@...vell.com, kuba@...nel.org,
        linux-kernel@...r.kernel.org, mschmidt@...hat.com,
        netdev@...r.kernel.org, sburla@...vell.com, sedara@...vell.com,
        vburru@...vell.com, vimleshk@...vell.com
Subject: Re: [net PATCH] octeon_ep: fix tx dma unmap len values in SG

On Tue, 2023-09-12 at 00:04 -0700, Shinas Rasheed wrote:
> This change is required in octep_iq_process_completions, as given in the patch,
> since the scatter gather pointer lengths arrive as big-endian in hardware.

I guess Simon intended asking about octep_iq_free_pending(), and AFAICT
your reply confirm that the change is required there, too.

Additionally the changelog really need to be expanded. I don't
understand how this change relates to endianess: if the ring format is
big endian I expect some be16_to_cpu(len) instead of complement-to-4 of
indexes.

Please clarify and expand the changelog, thanks!

Paolo