linux-kernel - Re: [EXT] Re: [net PATCH] octeon_ep: fix tx dma unmap len values in SG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH0PR18MB47346CADA6D087CB1BF2234CC7F0A@PH0PR18MB4734.namprd18.prod.outlook.com>
Date:   Wed, 13 Sep 2023 05:49:05 +0000
From:   Shinas Rasheed <srasheed@...vell.com>
To:     Paolo Abeni <pabeni@...hat.com>,
        "horms@...nel.org" <horms@...nel.org>
CC:     Abhijit Ayarekar <aayarekar@...vell.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "egallen@...hat.com" <egallen@...hat.com>,
        Haseeb Gani <hgani@...vell.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mschmidt@...hat.com" <mschmidt@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Satananda Burla <sburla@...vell.com>,
        Sathesh B Edara <sedara@...vell.com>,
        Veerasenareddy Burru <vburru@...vell.com>,
        Vimlesh Kumar <vimleshk@...vell.com>
Subject: Re: [EXT] Re: [net PATCH] octeon_ep: fix tx dma unmap len values in
 SG

Hi Paolo, Hi Simon,


From: Paolo Abeni <pabeni@...hat.com>
Sent: Tuesday, September 12, 2023 2:15 PM
To: Shinas Rasheed <srasheed@...vell.com>; horms@...nel.org <horms@...nel.org>
Cc: Abhijit Ayarekar <aayarekar@...vell.com>; davem@...emloft.net <davem@...emloft.net>; edumazet@...gle.com <edumazet@...gle.com>; egallen@...hat.com <egallen@...hat.com>; Haseeb Gani <hgani@...vell.com>; kuba@...nel.org <kuba@...nel.org>; linux-kernel@...r.kernel.org <linux-kernel@...r.kernel.org>; mschmidt@...hat.com <mschmidt@...hat.com>; netdev@...r.kernel.org <netdev@...r.kernel.org>; Satananda Burla <sburla@...vell.com>; Sathesh B Edara <sedara@...vell.com>; Veerasenareddy Burru <vburru@...vell.com>; Vimlesh Kumar <vimleshk@...vell.com>
Subject: [EXT] Re: [net PATCH] octeon_ep: fix tx dma unmap len values in SG 
 
External Email

----------------------------------------------------------------------


>I guess Simon intended asking about octep_iq_free_pending(), and AFAICT
your reply confirm that the change is required there, too.

You are correct in that the change is also required in octep_iq_free_pending as well. Thanks for pointing that out!
I will submit another version of this patchset including that.

>Additionally the changelog really need to be expanded. I don't
understand how this change relates to endianess: if the ring format is
big endian I expect some be16_to_cpu(len) instead of complement-to-4 of
indexes.


The bytes are in itself not big endian, but rather the each of the 16 bytes are kept in memory in
a kind of big-endian order. Apologizing for the confusion.

63              48 47             32  31           16 15       0
|      Len0       |     Len1         |   Len2         |   Len3  |

I shall provide an ascii figure like above in the code to explain and also update the changelog accordingly. Thanks for your time!