linux-kernel - Re: [PATCH] [v2] ASoC: dwc: fix typo in comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <64683b6c-1e31-4037-a47d-b8a19ea77c72@sirena.org.uk>
Date:   Wed, 13 Sep 2023 18:52:47 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Myunguk Kim <mwkim@...nchips.com>
Cc:     alsa-devel@...a-project.org, fido_max@...ox.ru,
        kuninori.morimoto.gx@...esas.com, lgirdwood@...il.com,
        linux-kernel@...r.kernel.org, perex@...ex.cz, tiwai@...e.com,
        u.kleine-koenig@...gutronix.de, xingyu.wu@...rfivetech.com
Subject: Re: [PATCH] [v2] ASoC: dwc: fix typo in comment

On Wed, Sep 13, 2023 at 11:41:04AM +0900, Myunguk Kim wrote:
> ISR_RXFO means "Status of Data Overrun interrupt for the RX channel"
> according to the datasheet.
> 
> So, the comment should be RX, not TX

This patch still doesn't apply:

>  
> -		/* Error Handling: TX */
> +		/* Error Handling: RX */
>  		if (isr[i] & ISR_RXFO) 
> { 			dev_err_ratelimited(dev->dev, "RX overrun (ch_id=%d)\n", i);

The patch is obviously corrupted, the { there should be on the prior
line and even fixing that by hand there appear to be some other issues.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)