linux-kernel - Re: [PATCH] [v2] ASoC: dwc: fix typo in comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZQFkTYqZ-QWxCjFu@debian.me>
Date:   Wed, 13 Sep 2023 14:27:09 +0700
From:   Bagas Sanjaya <bagasdotme@...il.com>
To:     Myunguk Kim <mwkim@...nchips.com>, alsa-devel@...a-project.org
Cc:     broonie@...nel.org, fido_max@...ox.ru,
        kuninori.morimoto.gx@...esas.com, lgirdwood@...il.com,
        linux-kernel@...r.kernel.org, perex@...ex.cz, tiwai@...e.com,
        u.kleine-koenig@...gutronix.de, xingyu.wu@...rfivetech.com
Subject: Re: [PATCH] [v2] ASoC: dwc: fix typo in comment

On Wed, Sep 13, 2023 at 11:41:04AM +0900, Myunguk Kim wrote:
> ISR_RXFO means "Status of Data Overrun interrupt for the RX channel"
> according to the datasheet.
> 
> So, the comment should be RX, not TX

Thanks for better description!

The patch title though, I'd like to write it as "ASoC: dwc: correct ISR_RXFO
check comment".

> 
> Signed-off-by: Myunguk Kim <mwkim@...nchips.com>
> ---
>  sound/soc/dwc/dwc-i2s.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/dwc/dwc-i2s.c b/sound/soc/dwc/dwc-i2s.c
> index 22c004179214..c71c17ef961d 100644
> --- a/sound/soc/dwc/dwc-i2s.c
> +++ b/sound/soc/dwc/dwc-i2s.c
> @@ -138,7 +138,7 @@ static irqreturn_t i2s_irq_handler(int irq, void *dev_id)
>  			irq_valid = true;
>  		}
>  
> -		/* Error Handling: TX */
> +		/* Error Handling: RX */
>  		if (isr[i] & ISR_RXFO) 
> { 			dev_err_ratelimited(dev->dev, "RX overrun (ch_id=%d)\n", i);
>  			irq_valid = true;

In any case,

Reviewed-by: Bagas Sanjaya <bagasdotme@...il.com>

-- 
An old man doll... just what I always wanted! - Clara

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)