linux-kernel - Re: [PATCH v3 -next] keys: Remove unused extern declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHC9VhSisEfQd0KCu7f8yKBwnrduFOPhP2SzWDfXiuvGh2g13A@mail.gmail.com>
Date:   Wed, 13 Sep 2023 14:00:53 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     dhowells@...hat.com, jarkko@...nel.org
Cc:     Yue Haibing <yuehaibing@...wei.com>, jmorris@...ei.org,
        serge@...lyn.com, keyrings@...r.kernel.org,
        linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 -next] keys: Remove unused extern declarations

On Mon, Aug 7, 2023 at 5:46 PM Paul Moore <paul@...l-moore.com> wrote:
> On Fri, Jul 28, 2023 at 10:40 PM Yue Haibing <yuehaibing@...wei.com> wrote:
> >
> > From: YueHaibing <yuehaibing@...wei.com>
> >
> > Since commit b2a4df200d57 ("KEYS: Expand the capacity of a keyring")
> > iterate_over_keyring() is never used, so can be removed.
> >
> > And commit b5f545c880a2 ("[PATCH] keys: Permit running process to instantiate keys")
> > left behind keyring_search_instkey().
> >
> > Fixes: b2a4df200d57 ("KEYS: Expand the capacity of a keyring")
> > Fixes: b5f545c880a2 ("[PATCH] keys: Permit running process to instantiate keys")
> > Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> > ---
> > v3: Add Fixes tag
> > v2: Also remove keyring_search_instkey()
> > ---
> >  security/keys/internal.h | 7 -------
> >  1 file changed, 7 deletions(-)
>
> Reviewed-by: Paul Moore <paul@...l-moore.com>

Jarkko or David, please merge this or explain what is wrong with this patch.

> > diff --git a/security/keys/internal.h b/security/keys/internal.h
> > index 3c1e7122076b..471cf36dedc0 100644
> > --- a/security/keys/internal.h
> > +++ b/security/keys/internal.h
> > @@ -109,13 +109,6 @@ extern void __key_link_end(struct key *keyring,
> >  extern key_ref_t find_key_to_update(key_ref_t keyring_ref,
> >                                     const struct keyring_index_key *index_key);
> >
> > -extern struct key *keyring_search_instkey(struct key *keyring,
> > -                                         key_serial_t target_id);
> > -
> > -extern int iterate_over_keyring(const struct key *keyring,
> > -                               int (*func)(const struct key *key, void *data),
> > -                               void *data);
> > -
> >  struct keyring_search_context {
> >         struct keyring_index_key index_key;
> >         const struct cred       *cred;
> > --
> > 2.34.1

-- 
paul-moore.com