linux-kernel - Re: [PATCH v3 -next] keys: Remove unused extern declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <CVI1FHKRSG47.2CV547I19B9ZT@suppilovahvero>
Date:   Wed, 13 Sep 2023 22:31:11 +0300
From:   "Jarkko Sakkinen" <jarkko@...nel.org>
To:     "Paul Moore" <paul@...l-moore.com>, <dhowells@...hat.com>
Cc:     "Yue Haibing" <yuehaibing@...wei.com>, <jmorris@...ei.org>,
        <serge@...lyn.com>, <keyrings@...r.kernel.org>,
        <linux-security-module@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 -next] keys: Remove unused extern declarations

On Wed Sep 13, 2023 at 9:00 PM EEST, Paul Moore wrote:
> On Mon, Aug 7, 2023 at 5:46 PM Paul Moore <paul@...l-moore.com> wrote:
> > On Fri, Jul 28, 2023 at 10:40 PM Yue Haibing <yuehaibing@...wei.com> wrote:
> > >
> > > From: YueHaibing <yuehaibing@...wei.com>
> > >
> > > Since commit b2a4df200d57 ("KEYS: Expand the capacity of a keyring")
> > > iterate_over_keyring() is never used, so can be removed.
> > >
> > > And commit b5f545c880a2 ("[PATCH] keys: Permit running process to instantiate keys")
> > > left behind keyring_search_instkey().
> > >
> > > Fixes: b2a4df200d57 ("KEYS: Expand the capacity of a keyring")
> > > Fixes: b5f545c880a2 ("[PATCH] keys: Permit running process to instantiate keys")
> > > Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> > > ---
> > > v3: Add Fixes tag
> > > v2: Also remove keyring_search_instkey()
> > > ---
> > >  security/keys/internal.h | 7 -------
> > >  1 file changed, 7 deletions(-)
> >
> > Reviewed-by: Paul Moore <paul@...l-moore.com>
>
> Jarkko or David, please merge this or explain what is wrong with this patch.

Sorry, I was aiming to pick this, and thanks for reminding.

Applied.

BR, Jarkko