linux-kernel - Re: [PATCH 1/2] tty/serial: Sort drivers in makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e74982c0-4942-1c46-1c53-6dd6e7677373@kernel.org>
Date:   Wed, 13 Sep 2023 07:29:51 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-serial@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] tty/serial: Sort drivers in makefile

On 12. 09. 23, 12:35, Ilpo Järvinen wrote:
> Sort drivers in alphabetic order in Makefile to make it easier to find
> the correct line. In case the CONFIG and filenames disagree, sort using
> the filename (but ignoring "serial" prefixes).

Overall looks good.

I just want to make sure you considered the below, as you don't say 
explicitly in the commit log.

The order in the makefile defines the link order. So built-in drivers 
are loaded in that order. So are you sure your patch doesn't change 
order of some drivers which need to be in a specific order?

thanks,
-- 
js
suse labs