linux-kernel - Re: [PATCH 1/2] tty/serial: Sort drivers in makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e25ef4f-48bb-eeff-f181-794afe716a81@linux.intel.com>
Date:   Wed, 13 Sep 2023 13:36:30 +0300 (EEST)
From:   Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To:     Jiri Slaby <jirislaby@...nel.org>
cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-serial <linux-serial@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] tty/serial: Sort drivers in makefile

On Wed, 13 Sep 2023, Jiri Slaby wrote:

> On 12. 09. 23, 12:35, Ilpo Järvinen wrote:
> > Sort drivers in alphabetic order in Makefile to make it easier to find
> > the correct line. In case the CONFIG and filenames disagree, sort using
> > the filename (but ignoring "serial" prefixes).
> 
> Overall looks good.
> 
> I just want to make sure you considered the below, as you don't say explicitly
> in the commit log.
> 
> The order in the makefile defines the link order. So built-in drivers are
> loaded in that order. So are you sure your patch doesn't change order of some
> drivers which need to be in a specific order?

Thanks for taking a look.

I limited the ordering to non-library like "leaf" driver files so it 
should be safe. Except for 8250_early that was in middle of drivers so
I moved it before the driver section but that doesn't alter anything 
important AFAICT.

In any case, I double-checked this again and only thing I found out is 
that for some reason SERIAL_8250_EXAR depends on 8250_PCI but nothing uses 
the 4 functions 8250_pci.c EXPORTs (which I'll address shortly).

-- 
 i.