linux-kernel - Re: [PATCH V2 4/5] ASoC: codecs: Change the aw88261 variable name and i2c driver name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230913080017.364430-1-wangweidong.a@awinic.com>
Date:   Wed, 13 Sep 2023 16:00:17 +0800
From:   wangweidong.a@...nic.com
To:     krzysztof.kozlowski@...aro.org
Cc:     13916275206@....com, alsa-devel@...a-project.org, arnd@...db.de,
        broonie@...nel.org, ckeepax@...nsource.cirrus.com,
        colin.i.king@...il.com, conor+dt@...nel.org,
        devicetree@...r.kernel.org, fido_max@...ox.ru,
        harshit.m.mogalapalli@...cle.com, herve.codina@...tlin.com,
        krzysztof.kozlowski+dt@...aro.org, lgirdwood@...il.com,
        linus.walleij@...aro.org, linux-kernel@...r.kernel.org,
        liweilei@...nic.com, perex@...ex.cz, povik+lin@...ebit.org,
        rf@...nsource.cirrus.com, robh+dt@...nel.org, ryans.lee@...log.com,
        sebastian.reichel@...labora.com, shumingf@...ltek.com,
        tiwai@...e.com, trix@...hat.com, wangweidong.a@...nic.com,
        yijiangtao@...nic.com
Subject: Re: [PATCH V2 4/5] ASoC: codecs: Change the aw88261 variable name and i2c driver name

Thank you very much for your review.

On 13/09/2023 09:03, krzysztof.kozlowski@...aro.org wrote:
> On 12/09/2023 08:58, wangweidong.a@...nic.com wrote:
>> From: Weidong Wang <wangweidong.a@...nic.com>
>> 
>> Change "sound-channel" to "awinic,audio-channel"
>> Change "aw88261_smartpa" to "aw88261"

I'll add "This change is for consistency with yaml properties" to the commit message.

>> -	prof_name = aw88261_dev_get_prof_name(aw88261->aw_pa, count);
>> -	if (!prof_name) {
>> +	ret = aw88261_dev_get_prof_name(aw88261->aw_pa, count, &prof_name);
>> +	if (ret) {
>>  		strscpy(uinfo->value.enumerated.name, "null",
>>  						strlen("null") + 1);
>>  		return 0;
>> @@ -1189,7 +1190,7 @@ static void aw88261_parse_channel_dt(struct aw88261 *aw88261)
>>  	u32 channel_value = AW88261_DEV_DEFAULT_CH;
>>  	u32 sync_enable = false;
>>  
>> -	of_property_read_u32(np, "sound-channel", &channel_value);
>> +	of_property_read_u32(np, "awinic,audio-channel", &channel_value);
>>  	of_property_read_u32(np, "sync-flag", &sync_enable);

> What about this?

This change is to be consistent with the name in the yaml file

Best regards,
Weidong Wang