linux-kernel - Re: [PATCH V2 1/5] ASoC: dt-bindings: Adds properties to "awinic,aw88395"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230913080310.364486-1-wangweidong.a@awinic.com>
Date:   Wed, 13 Sep 2023 16:03:10 +0800
From:   wangweidong.a@...nic.com
To:     krzysztof.kozlowski@...aro.org
Cc:     13916275206@....com, alsa-devel@...a-project.org, arnd@...db.de,
        broonie@...nel.org, ckeepax@...nsource.cirrus.com,
        colin.i.king@...il.com, conor+dt@...nel.org,
        devicetree@...r.kernel.org, fido_max@...ox.ru,
        harshit.m.mogalapalli@...cle.com, herve.codina@...tlin.com,
        krzysztof.kozlowski+dt@...aro.org, lgirdwood@...il.com,
        linus.walleij@...aro.org, linux-kernel@...r.kernel.org,
        liweilei@...nic.com, perex@...ex.cz, povik+lin@...ebit.org,
        rf@...nsource.cirrus.com, robh+dt@...nel.org, ryans.lee@...log.com,
        sebastian.reichel@...labora.com, shumingf@...ltek.com,
        tiwai@...e.com, trix@...hat.com, wangweidong.a@...nic.com,
        yijiangtao@...nic.com
Subject: Re: [PATCH V2 1/5] ASoC: dt-bindings: Adds properties to "awinic,aw88395"

Thank you very much for your review, but I have a question that I would like to consult

On 13/09/2023 09:03, krzysztof.kozlowski@...aro.org wrote:
> On 12/09/2023 08:58, wangweidong.a@...nic.com wrote:
>> From: Weidong Wang <wangweidong.a@...nic.com>
>> 
>> Adds properties to "awinic,aw88395" to make files more complete
>> 
>> Signed-off-by: Weidong Wang <wangweidong.a@...nic.com>
>> ---
>>  .../bindings/sound/awinic,aw88395.yaml        | 19 +++++++++++++++++++
>>  1 file changed, 19 insertions(+)
>> 
>> diff --git a/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml b/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml
>> index 4051c2538caf..4965aa4a5370 100644
>> --- a/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml
>> +++ b/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml
>> @@ -32,11 +32,28 @@ properties:
>>    reset-gpios:
>>     maxItems: 1
>>  
>> +  awinic,audio-channel:
>> +    description:
>> +      It is used to distinguish multiple PA devices, so that different
>> +      configurations can be loaded to different PA devices
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +    minimum: 0
>> +    maximum: 7
>> +
>> +  awinic,sync-flag:
>> +    description:
>> +      Flag bit used to keep the phase synchronized in the case of multiple PA
>> +    $ref: /schemas/types.yaml#/definitions/uint32

> Looks like bool, not uint32. If you made it uint32 for some future
> purpose, then the name "flag" is misleading and anyway what would be the
> third option here for sync?

Thank you very much. Can I Change it to "$ref: /schemas/types.yaml#/definitions/bool"?

Best regards,
Weidong Wang