linux-kernel - Re: [PATCH v2 13/14] arm64: dts: qcom: msm8996: Remove PNoC clock from MSS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 13 Sep 2023 10:29:00 +0000
From:   Yassine Oudjana <y.oudjana@...tonmail.com>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Sibi Sankar <quic_sibis@...cinc.com>,
        Will Deacon <will@...nel.org>,
        Robin Murphy <robin.murphy@....com>,
        Joerg Roedel <joro@...tes.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Wesley Cheng <quic_wcheng@...cinc.com>
Cc:     Marijn Suijten <marijn.suijten@...ainline.org>,
        Alexey Minnekhanov <alexeymin@...tmarketos.org>,
        linux-arm-msm@...r.kernel.org, linux-remoteproc@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, iommu@...ts.linux.dev,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH v2 13/14] arm64: dts: qcom: msm8996: Remove PNoC clock from MSS

On 12/09/2023 4:31 pm, Konrad Dybcio wrote:
> The PNoC clock is a clock for the entire PNoC bus, managed from
> within the interconnect driver. Attaching it to MSS was a total hack.
> Get rid of it and take the liberty to make the clock-names entries
> more readable.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
> ---
>   arch/arm64/boot/dts/qcom/msm8996.dtsi | 11 ++++++++---
>   1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index 7061a8e12c81..51db5ddcef88 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -2479,10 +2479,15 @@ mss_pil: remoteproc@...0000 {
>   				 <&gcc GCC_MSS_GPLL0_DIV_CLK>,
>   				 <&gcc GCC_MSS_SNOC_AXI_CLK>,
>   				 <&gcc GCC_MSS_MNOC_BIMC_AXI_CLK>,
> -				 <&rpmcc RPM_SMD_PCNOC_CLK>,
>   				 <&rpmcc RPM_SMD_QDSS_CLK>;
> -			clock-names = "iface", "bus", "mem", "xo", "gpll0_mss",
> -				      "snoc_axi", "mnoc_axi", "pnoc", "qdss";
> +			clock-names = "iface",
> +				      "bus",
> +				      "mem",
> +				      "xo",
> +				      "gpll0_mss",
> +				      "snoc_axi",
> +				      "mnoc_axi",
> +				      "qdss";
>   
>   			resets = <&gcc GCC_MSS_RESTART>;
>   			reset-names = "mss_restart";

Tested-by: Yassine Oudjana <y.oudjana@...tonmail.com>