linux-kernel - Re: [PATCH -next] md: simplify md_seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230913123222.00006a8e@linux.intel.com>
Date:   Wed, 13 Sep 2023 12:32:22 +0200
From:   Mariusz Tkaczyk <mariusz.tkaczyk@...ux.intel.com>
To:     Yu Kuai <yukuai1@...weicloud.com>
Cc:     song@...nel.org, linux-raid@...r.kernel.org,
        linux-kernel@...r.kernel.org, yi.zhang@...wei.com,
        yangerkun@...wei.com, "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH -next] md: simplify md_seq_ops

On Tue, 12 Sep 2023 09:02:19 +0800
Yu Kuai <yukuai1@...weicloud.com> wrote:

> >> +static void *md_seq_next(struct seq_file *seq, void *v, loff_t *pos)
> >> +{
> >> +	return seq_list_next(v, &all_mddevs, pos);
> >> +}  
> > Can it be so simple? Why previous versions takes care of holding "(void)*1"
> > and "(void)*2" then? Could you elaborate?  
> 
> "1" means printing "Personalities", which is now moved to md_seq_start,
> and "2" means printing "unsed devices" which is now moved to
> md_seq_stop. And now md_seq_next is only used to iterate the mddev list.
> 

Ok, LGTM.

Mariusz