[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CACRpkdah0+HjQ3Co=eHitK8srbWgT7e956+oeH-K+yjYs9=iuw@mail.gmail.com>
Date: Thu, 14 Sep 2023 15:55:22 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Paul Cercueil <paul@...pouillou.net>,
Andy Shevchenko <andy.shevchenko@...il.com>,
Miquel Raynal <miquel.raynal@...tlin.com>,
Andy Shevchenko <andy@...nel.org>,
Ulf Hansson <ulf.hansson@...aro.org>,
Harvey Hunt <harveyhuntnexus@...il.com>,
Richard Weinberger <richard@....at>,
Vignesh Raghavendra <vigneshr@...com>,
Daniel Scally <djrscally@...il.com>,
Hans de Goede <hdegoede@...hat.com>,
Mark Gross <markgross@...nel.org>,
Heiner Kallweit <hkallweit1@...il.com>,
linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-mmc@...r.kernel.org, linux-mips@...r.kernel.org,
linux-mtd@...ts.infradead.org, platform-driver-x86@...r.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH 2/5] mtd: rawnand: ingenic: use gpiod_set_active_high()
On Thu, Sep 14, 2023 at 11:30 AM Bartosz Golaszewski <brgl@...ev.pl> wrote:
> On Thu, Sep 14, 2023 at 10:30 AM Paul Cercueil <paul@...pouillou.net> wrote:
> > > I believe Linus was for moving.
Yes.
> > Which Linus? Because the one who's also the gpio maintainer just wrote
> > above that it was better to keep it in the driver.
What. No. I expressed myself unclearly:
> > Why not moving this quirk to gpiolib-of.c?
>
> That's a better idea here I think, it's clearly a quirk for a
> buggy device tree.
"That's a better idea here I think"
means
"That's a better idea [IN THIS CASE] I think"
i.e. in this case it is a better idea to move it into gpiolib-of.c
> I'm also under the impression that Linus meant moving it to gpiolib-of.c. Let's
>
> Linus: Could you clarify?
Yes.
I invented that thing so I'm a fan of it.
Yours,
Linus Walleij
Powered by blists - more mailing lists