linux-kernel - Re: [PATCH] scsi: ufs: qcom: dt-bindings: Add MCQ ESI property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ee823de5-d5b4-6719-a7e3-cc799cd15ad1@quicinc.com>
Date:   Thu, 14 Sep 2023 09:59:19 +0800
From:   Ziqi Chen <quic_ziqichen@...cinc.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        <quic_asutoshd@...cinc.com>, <quic_cang@...cinc.com>,
        <bvanassche@....org>, <mani@...nel.org>, <adrian.hunter@...el.com>,
        <beanhuo@...ron.com>, <avri.altman@....com>,
        <junwoo80.lee@...sung.com>, <martin.petersen@...cle.com>,
        <quic_nguyenb@...cinc.com>, <quic_nitirawa@...cinc.com>
CC:     <linux-scsi@...r.kernel.org>, Andy Gross <agross@...nel.org>,
        "Bjorn Andersson" <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        "open list:ARM/QUALCOMM SUPPORT" <linux-arm-msm@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: ufs: qcom: dt-bindings: Add MCQ ESI property

Hi Krzysztof，

Thanks for your comment very much ~
I will remove this property in next patch version.
We just plan to post "msi-parent" property for MCQ.


Best Regards,
Ziqi

On 9/11/2023 2:27 PM, Krzysztof Kozlowski wrote:
> On 08/09/2023 10:53, Ziqi Chen wrote:
>> Document the description for the qcom,esi-affinity-mask.
> 
> This tells me nothing what is this feature for.
> 
>>
>> Signed-off-by: Ziqi Chen <quic_ziqichen@...cinc.com>
>> ---
>>   Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
>> index bdfa86a..323595f 100644
>> --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
>> +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
>> @@ -97,6 +97,10 @@ properties:
>>       description:
>>         GPIO connected to the RESET pin of the UFS memory device.
>>   
>> +  qcom,esi-affinity-mask:
> 
> Not tested. You also miss proper type.
> 
>> +    description:
>> +       UFS MCQ ESI affinity mask. Affine ESI on registration according to this CPU mask.
> 
> And why is this a property of DT? Aren't you now describing driver?
> 
> 
> 
> Best regards,
> Krzysztof
>