linux-kernel - Re: [PATCH v3] sched/topology: remove sysctl_sched_energy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46ef47cf-4aea-65ed-09e1-ad8562b4e693@linux.vnet.ibm.com>
Date:   Thu, 14 Sep 2023 23:29:31 +0530
From:   Shrikanth Hegde <sshegde@...ux.vnet.ibm.com>
To:     kernel test robot <lkp@...el.com>
Cc:     oe-kbuild-all@...ts.linux.dev, dietmar.eggemann@....com,
        vschneid@...hat.com, linux-kernel@...r.kernel.org,
        ionela.voinescu@....com, quentin.perret@....com,
        srikar@...ux.vnet.ibm.com, mgorman@...hsingularity.net,
        mingo@...nel.org, pierre.gondois@....com, yu.c.chen@...el.com,
        tim.c.chen@...ux.intel.com, mingo@...hat.com,
        vincent.guittot@...aro.org
Subject: Re: [PATCH v3] sched/topology: remove sysctl_sched_energy_aware
 depending on the architecture



On 9/14/23 5:31 AM, kernel test robot wrote:
> Hi Shrikanth,
> 
> kernel test robot noticed the following build warnings:
> 
> [auto build test WARNING on tip/sched/core]
> [also build test WARNING on linus/master v6.6-rc1 next-20230913]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Shrikanth-Hegde/sched-topology-remove-sysctl_sched_energy_aware-depending-on-the-architecture/20230913-195055
> base:   tip/sched/core
> patch link:    https://lore.kernel.org/r/20230913114807.665094-1-sshegde%40linux.vnet.ibm.com
> patch subject: [PATCH v3] sched/topology: remove sysctl_sched_energy_aware depending on the architecture
> config: x86_64-buildonly-randconfig-003-20230914 (https://download.01.org/0day-ci/archive/20230914/202309140704.YiAtZ0yy-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230914/202309140704.YiAtZ0yy-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202309140704.YiAtZ0yy-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
>    In file included from kernel/sched/build_utility.c:89:
>>> kernel/sched/topology.c:212:33: warning: 'sysctl_eas_header' defined but not used [-Wunused-variable]
>      212 | static struct ctl_table_header *sysctl_eas_header;
>          |                                 ^~~~~~~~~~~~~~~~~
> 

Hi. 

Thanks for pointing it out. This could be done by setting CONFIG_PROC_SYSCTL=n
have refactored the code and it likely make it simpler. will send out v4. 


> 
> vim +/sysctl_eas_header +212 kernel/sched/topology.c
> 
>    208	
>    209	#if defined(CONFIG_ENERGY_MODEL) && defined(CONFIG_CPU_FREQ_GOV_SCHEDUTIL)
>    210	DEFINE_STATIC_KEY_FALSE(sched_energy_present);
>    211	static unsigned int sysctl_sched_energy_aware;
>  > 212	static struct ctl_table_header *sysctl_eas_header;
>    213	static DEFINE_MUTEX(sched_energy_mutex);
>    214	static bool sched_energy_update;
>    215	static bool is_sysctl_eas_changing;
>    216	
>