linux-kernel - Re: [PATCH v9 07/11] btrfs: zoned: allow zoned RAID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230914175959.GA20408@twin.jikos.cz>
Date:   Thu, 14 Sep 2023 19:59:59 +0200
From:   David Sterba <dsterba@...e.cz>
To:     Johannes Thumshirn <johannes.thumshirn@....com>
Cc:     Chris Mason <clm@...com>, Josef Bacik <josef@...icpanda.com>,
        David Sterba <dsterba@...e.com>,
        Christoph Hellwig <hch@....de>,
        Naohiro Aota <naohiro.aota@....com>, Qu Wenruo <wqu@...e.com>,
        Damien Le Moal <dlemoal@...nel.org>,
        linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v9 07/11] btrfs: zoned: allow zoned RAID

On Thu, Sep 14, 2023 at 09:07:02AM -0700, Johannes Thumshirn wrote:
> --- a/fs/btrfs/zoned.c
> +++ b/fs/btrfs/zoned.c
> @@ -1397,9 +1397,11 @@ static int btrfs_load_block_group_dup(struct btrfs_block_group *bg,
>  				      struct zone_info *zone_info,
>  				      unsigned long *active)
>  {
> -	if (map->type & BTRFS_BLOCK_GROUP_DATA) {
> -		btrfs_err(bg->fs_info,
> -			  "zoned: profile DUP not yet supported on data bg");
> +	struct btrfs_fs_info *fs_info = bg->fs_info;
> +
> +	if (map->type & BTRFS_BLOCK_GROUP_DATA &&
> +	    !fs_info->stripe_root) {
> +		btrfs_err(fs_info, "zoned: data DUP profile needs stripe_root");

Using stripe_root for identifier is ok so we don't have overly long ones
but for user messages please use raid-stripe-tree. Fixed.