linux-kernel - Re: [PATCH] Documentation: kbuild: explain handling optional dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 14 Sep 2023 05:51:32 +0200
From:   Nicolas Schier <nicolas@...sle.eu>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Arnd Bergmann <arnd@...nel.org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Jonathan Corbet <corbet@....net>,
        Sakari Ailus <sakari.ailus@....fi>,
        Javier Martinez Canillas <javierm@...hat.com>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        linux-kbuild@...r.kernel.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Documentation: kbuild: explain handling optional
 dependencies

On Wed 13 Sep 2023 23:16:47 GMT, Arnd Bergmann wrote:
> On Wed, Sep 13, 2023, at 22:34, Nicolas Schier wrote:
> > On Wed, Sep 13, 2023 at 09:55:36PM +0200 Arnd Bergmann wrote:
> 
> >>    config FOO
> >> -       bool "Support for foo hardware"
> >> +       tristate "Support for foo hardware"
> >>         depends on BAR || !BAR
> >
> > ah, thanks, tristate kconfig symbols are really more interesting.  But I am
> > still not sure, whether this works as proposed:
> >
> > With the 'config FOO' above and
> >
> >   config BAR
> >   	tristate "Support for bar feature"
> >
> > kconfig allows me to choose between these:
> >
> > BAR=y  => FOO={N/m/y}
> > BAR=m  => FOO={N/m}
> > BAR=n  => FOO={N/m/y}
> >
> > But with
> >
> >   config FOO
> >   	tristate "Support for foo hardware"
> >   	depends on !BAR=m
> >
> > I can choose between:
> >
> > BAR=y  => FOO={N/m/y}
> > BAR=m  => FOO is not selectable
> > BAR=n  => FOO={N/m/y}
> 
> That is indeed the point: if BAR=m, we want to be able to pick FOO=m
> here, otherwise it is impossible to enabled everything as modules.

oh, I misinterpreted your very first sentence; thanks for clarifying it to me
and sorry for the noise.
With the minor fixes:

Reviewed-by: Nicolas Schier <nicolas@...sle.eu>

Kind regards,
Nicolas

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)