linux-kernel - [PATCH] iio: adc: ti_am335x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230914121300.845493-1-w.egorov@phytec.de>
Date:   Thu, 14 Sep 2023 14:13:00 +0200
From:   Wadim Egorov <w.egorov@...tec.de>
To:     <jic23@...nel.org>, <lars@...afoo.de>, <robh@...nel.org>,
        <heiko@...ech.de>, <mugunthanvnm@...com>, <peter.ujfalusi@...com>
CC:     <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <upstream@...ts.phytec.de>, <nm@...com>
Subject: [PATCH] iio: adc: ti_am335x_adc: Make DMAs optional

DMAs are optional. Even if the DMA request is unsuccessfully,
the ADC can still work properly.
Make tiadc_request_dma() not fail if we do not provide dmas &
dma-names properties.

This actually fixes the wrong error handling of the tiadc_request_dma()
result where the probing only failed if -EPROPE_DEFER was returned.

Fixes: f438b9da75eb ("drivers: iio: ti_am335x_adc: add dma support")

Signed-off-by: Wadim Egorov <w.egorov@...tec.de>
---
 drivers/iio/adc/ti_am335x_adc.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c
index 8db7a01cb5fb..e14aa9254ab1 100644
--- a/drivers/iio/adc/ti_am335x_adc.c
+++ b/drivers/iio/adc/ti_am335x_adc.c
@@ -543,8 +543,11 @@ static int tiadc_request_dma(struct platform_device *pdev,
 	if (IS_ERR(dma->chan)) {
 		int ret = PTR_ERR(dma->chan);
 
+		if (ret != -ENODEV)
+			return dev_err_probe(&pdev->dev, ret,
+					     "RX DMA channel request failed\n");
 		dma->chan = NULL;
-		return ret;
+		return 0;
 	}
 
 	/* RX buffer */
@@ -670,7 +673,7 @@ static int tiadc_probe(struct platform_device *pdev)
 	platform_set_drvdata(pdev, indio_dev);
 
 	err = tiadc_request_dma(pdev, adc_dev);
-	if (err && err == -EPROBE_DEFER)
+	if (err)
 		goto err_dma;
 
 	return 0;
-- 
2.25.1