linux-kernel - Re: [GIT PULL] tracing: Add eventfs file to help with debugging any more issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=whbDQb5VzJbn6qQswxfbcp67uzfwpJ+R1DxHk0dHdg4pQ@mail.gmail.com>
Date:   Fri, 15 Sep 2023 14:30:38 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Ajay Kaher <akaher@...are.com>
Subject: Re: [GIT PULL] tracing: Add eventfs file to help with debugging any
 more issues

On Fri, 15 Sept 2023 at 14:13, Steven Rostedt <rostedt@...dmis.org> wrote:
>
> Are you entirely against this file, or is it fine if it's just wrapped
> around an CONFIG_EVENTFS_DEBUG?

Honestly, I think its' extra code that we'd carry around - probably
for much too long - with absolutely _zero_ indication that it's
actually worth it.

Not worth asking people about, but also not worth carrying around.

You worry about bugs in it now, because it's new code. That's normal.
That doesn't make your debug interface worth any kind of future.

Keep it around as a private patch. Send it out to people if there are
actual issues that might indicate this debug support would helkp. And
if it has shown itself to be useful several times, at that point you
have an argument for the code.

As it is, right now I look at that code and I see extra BS that we'll
carry around forever that helps *zero* users, and I find it very
questionable whether it would help you.

And if you really think that people need to know what the events exist
in eventfs, then dammit, make 'readdir()' see them. Not some stupid
specialty debug interface. That's what filesystems *have* readdir for.

              Linus