linux-kernel - Re: [GIT PULL] tracing: Add eventfs file to help with debugging any more issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wiheWEbUfQy1JY_BQ6mJukOLa6hEdEzN1N_hgz1nxY9hQ@mail.gmail.com>
Date:   Fri, 15 Sep 2023 14:35:40 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Ajay Kaher <akaher@...are.com>
Subject: Re: [GIT PULL] tracing: Add eventfs file to help with debugging any
 more issues

On Fri, 15 Sept 2023 at 14:30, Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
> And if you really think that people need to know what the events exist
> in eventfs, then dammit, make 'readdir()' see them. Not some stupid
> specialty debug interface. That's what filesystems *have* readdir for.

.. alternatively, if you have noticed that it's just a pain to not be
able to see the data, instead of introducing this completely separate
and illogical debug interface, just say "ok, it was a mistake, let's
go back to just keeping things in dentries since we can _see_ those".

Put another way: this is all self-inflicted damage, and you seem to
argue for this debug interface purely on "I can't see what's going on
any more, the old model was really nice because you could *see* the
events".

To me, if that's really a major issue, that just says "ok, this
eventfs abstraction was mis-designed, and hid data that the main
developer actually wants".

We don't add new debug interfaces just because you screwed up the
design. Fix it.

              Linus