linux-kernel - Re: [PATCH v2 8/8] arm64: defconfig: enable interconnect and pinctrl for SM4450

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <212f9bfa-6d4c-bba2-60d2-272c001a4322@quicinc.com>
Date:   Fri, 15 Sep 2023 19:25:58 -0700
From:   Trilok Soni <quic_tsoni@...cinc.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Tengfei Fan <quic_tengfan@...cinc.com>, <will@...nel.org>,
        <robin.murphy@....com>, <joro@...tes.org>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
        <agross@...nel.org>, <andersson@...nel.org>,
        <konrad.dybcio@...aro.org>, <catalin.marinas@....com>
CC:     <geert+renesas@...der.be>, <arnd@...db.de>,
        <neil.armstrong@...aro.org>, <nfraprado@...labora.com>,
        <rafal@...ecki.pl>, <peng.fan@....com>,
        <linux-arm-kernel@...ts.infradead.org>, <iommu@...ts.linux.dev>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <quic_shashim@...cinc.com>,
        <quic_kaushalk@...cinc.com>, <quic_tdas@...cinc.com>,
        <quic_tingweiz@...cinc.com>, <quic_aiquny@...cinc.com>,
        <kernel@...cinc.com>
Subject: Re: [PATCH v2 8/8] arm64: defconfig: enable interconnect and pinctrl
 for SM4450

On 9/15/2023 7:21 PM, Trilok Soni wrote:
> On 9/15/2023 4:29 AM, Krzysztof Kozlowski wrote:
>> On 15/09/2023 13:18, Tengfei Fan wrote:
>>>
>>>
>>> 在 9/15/2023 5:16 PM, Krzysztof Kozlowski 写道:
>>>> On 15/09/2023 11:12, Tengfei Fan wrote:
>>>>>
>>>>>
>>>>> 在 9/15/2023 3:21 PM, Krzysztof Kozlowski 写道:
>>>>>> On 15/09/2023 04:15, Tengfei Fan wrote:
>>>>>>> Add the SM4450 interconnect and pinctrl drivers as built-in for
>>>>>>> support the Qualcomm SM4450 platform to boot to uart shell.
>>>>>>>
>>>>>>> Signed-off-by: Tengfei Fan <quic_tengfan@...cinc.com>
>>>>>>> ---
>>>>>>>    arch/arm64/configs/defconfig | 2 ++
>>>>>>>    1 file changed, 2 insertions(+)
>>>>>>>
>>>>>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>>>>>>> index ec59174b14db..e91993de865e 100644
>>>>>>> --- a/arch/arm64/configs/defconfig
>>>>>>> +++ b/arch/arm64/configs/defconfig
>>>>>>> @@ -598,6 +598,7 @@ CONFIG_PINCTRL_SC8280XP=y
>>>>>>>    CONFIG_PINCTRL_SDM660=y
>>>>>>>    CONFIG_PINCTRL_SDM670=y
>>>>>>>    CONFIG_PINCTRL_SDM845=y
>>>>>>> +CONFIG_PINCTRL_SM4450=y
>>>>>>>    CONFIG_PINCTRL_SM6115=y
>>>>>>>    CONFIG_PINCTRL_SM6125=y
>>>>>>>    CONFIG_PINCTRL_SM6350=y
>>>>>>> @@ -1500,6 +1501,7 @@ CONFIG_INTERCONNECT_QCOM_SC7280=y
>>>>>>>    CONFIG_INTERCONNECT_QCOM_SC8180X=y
>>>>>>>    CONFIG_INTERCONNECT_QCOM_SC8280XP=y
>>>>>>>    CONFIG_INTERCONNECT_QCOM_SDM845=y
>>>>>>> +CONFIG_INTERCONNECT_QCOM_SM4450=y
>>>>>>
>>>>>> Why it cannot be =m?
>>>>>>
>>>>>> Best regards,
>>>>>> Krzysztof
>>>>>>
>>>>>
>>>>> Hi Krzysztof,
>>>>> Because system haven't capacity of loading ko files at this time on
>>>>> SM4450 platform, so setting to "Y".
>>>>
>>>> Hm? System has this capability. All systems have. What is so different
>>>> on SM4450 comparing to everything else we have here?
>>>>
>>>> No, this should be =m and you need to fix your system.
>>>>
>>>> Best regards,
>>>> Krzysztof
>>>>
>>> Hi Krzysztof,
>>> Find new way which can load ko files on SM4450 platform, still need use 
>>> "Y", because of some other modules have dependence to these two config, 
>>> like scm, smmu module drivers, uart shell console cannot be got if set 
>>> to "m".
>>
>> That's what I am asking, which device exactly needs it.
>>
>>>
>>> Also do test for setting these two config to "m" on SM8450 platform, get 
>>> uart shell consle failed if so setting.
>>
>> Yeah, this we know, I did this. I am asking about SM4450.
> 
> Why we have =m requirement when other drivers above are =Y?. Can we confirm
> w/ Georgi? I am not aware that Interconnect drivers needs to be =m only.
> 
> CONFIG_INTERCONNECT_QCOM_SC8180X=y
> CONFIG_INTERCONNECT_QCOM_SC8280XP=y
> CONFIG_INTERCONNECT_QCOM_SDM845=y

Complete list here, and it is inconsistent. Latest 8550 is also =y. Do we document
the reasons somewhere on why they are added as =y?

CONFIG_INTERCONNECT_QCOM=y
CONFIG_INTERCONNECT_QCOM_MSM8916=m
CONFIG_INTERCONNECT_QCOM_MSM8996=m
CONFIG_INTERCONNECT_QCOM_OSM_L3=m
CONFIG_INTERCONNECT_QCOM_QCM2290=m
CONFIG_INTERCONNECT_QCOM_QCS404=m
CONFIG_INTERCONNECT_QCOM_SA8775P=y
CONFIG_INTERCONNECT_QCOM_SC7180=y
CONFIG_INTERCONNECT_QCOM_SC7280=y
CONFIG_INTERCONNECT_QCOM_SC8180X=y
CONFIG_INTERCONNECT_QCOM_SC8280XP=y
CONFIG_INTERCONNECT_QCOM_SDM845=y
CONFIG_INTERCONNECT_QCOM_SM8150=m
CONFIG_INTERCONNECT_QCOM_SM8250=m
CONFIG_INTERCONNECT_QCOM_SM8350=m
CONFIG_INTERCONNECT_QCOM_SM8450=y
CONFIG_INTERCONNECT_QCOM_SM8550=y

-- 
---Trilok Soni