linux-kernel - Re: [patch V3 01/30] x86/microcode/32: Move early loading after paging enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1e2ecded-c1f6-462c-f66e-756a9d76c41d@intel.com>
Date:   Sat, 16 Sep 2023 02:03:03 -0700
From:   "Chang S. Bae" <chang.seok.bae@...el.com>
To:     Thomas Gleixner <tglx@...utronix.de>,
        LKML <linux-kernel@...r.kernel.org>
CC:     <x86@...nel.org>, Borislav Petkov <bp@...en8.de>,
        Arjan van de Ven <arjan@...ux.intel.com>,
        Nikolay Borisov <nik.borisov@...e.com>,
        Fenghua Yu <fenghua.yu@...el.com>, Peter Anvin <hpa@...or.com>
Subject: Re: [patch V3 01/30] x86/microcode/32: Move early loading after
 paging enable

On 9/12/2023 12:57 AM, Thomas Gleixner wrote:
> 
>   static int apply_microcode_early(struct ucode_cpu_info *uci, bool early)
>   {
...
> -	if (early)
> -		print_ucode(old_rev, uci->cpu_sig.rev, mc->hdr.date);
> -	else
> -		print_ucode_info(old_rev, uci->cpu_sig.rev, mc->hdr.date);
> -

Nitpick:

with this change, there is no need for the second argument -- 'bool early'.

Thanks,
Chang