linux-kernel - Re: [patch V3 01/30] x86/microcode/32: Move early loading after paging enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87jzsozk1e.ffs@tglx>
Date:   Sun, 17 Sep 2023 21:17:33 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     "Chang S. Bae" <chang.seok.bae@...el.com>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     x86@...nel.org, Borislav Petkov <bp@...en8.de>,
        Arjan van de Ven <arjan@...ux.intel.com>,
        Nikolay Borisov <nik.borisov@...e.com>,
        Fenghua Yu <fenghua.yu@...el.com>, Peter Anvin <hpa@...or.com>
Subject: Re: [patch V3 01/30] x86/microcode/32: Move early loading after
 paging enable

On Sat, Sep 16 2023 at 02:03, Chang S. Bae wrote:
> On 9/12/2023 12:57 AM, Thomas Gleixner wrote:
>> 
>>   static int apply_microcode_early(struct ucode_cpu_info *uci, bool early)
>>   {
> ...
>> -	if (early)
>> -		print_ucode(old_rev, uci->cpu_sig.rev, mc->hdr.date);
>> -	else
>> -		print_ucode_info(old_rev, uci->cpu_sig.rev, mc->hdr.date);
>> -
>
> Nitpick:
>
> with this change, there is no need for the second argument -- 'bool early'.

Duh. Yes ...