linux-kernel - Re: [PATCH v4 02/42] ARM: ep93xx: add swlocked prototypes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fbcd27f27c37cebbc565b6a0caac44b1590b6603.camel@gmail.com>
Date:   Mon, 18 Sep 2023 15:04:02 +0200
From:   Alexander Sverdlin <alexander.sverdlin@...il.com>
To:     nikita.shubin@...uefel.me,
        Linus Walleij <linus.walleij@...aro.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Sergey Shtylyov <s.shtylyov@....ru>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Damien Le Moal <dlemoal@...nel.org>,
        linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v4 02/42] ARM: ep93xx: add swlocked prototypes

Hi Nikita,

On Sat, 2023-09-16 at 17:38 +0200, Alexander Sverdlin wrote:
> > Add ep93xx_regmap_write and ep93xx_regmap_update_bits to make drivers
> > compilable before actual implementation is added.
> 
> It should be possible to re-arrange the patch series so that real
> implementation comes before the drivers using it.
> 
> We must assure that bisecting the kernel tree is possible, that
> means no matter which (initial) part of your series is applied, there is no
> regression allowed.
> 

sorry for the confusion, there is no bisectability problem in it
indeed, because only new drivers use it and they are not active until
the last patches in the series swith to DT.

I'd personally probably melt commit 10 ("soc: Add SoC driver for Cirrus ep93xx")
into this one, but I don't see it necessary after all.

> > Signed-off-by: Nikita Shubin <nikita.shubin@...uefel.me>
> > ---
> >  include/linux/soc/cirrus/ep93xx.h | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/include/linux/soc/cirrus/ep93xx.h b/include/linux/soc/cirrus/ep93xx.h
> > index 56fbe2dc59b1..8b4b8221ed4c 100644
> > --- a/include/linux/soc/cirrus/ep93xx.h
> > +++ b/include/linux/soc/cirrus/ep93xx.h
> > @@ -3,6 +3,7 @@
> >  #define _SOC_EP93XX_H
> >  
> >  struct platform_device;
> > +struct regmap;
> >  
> >  #define EP93XX_CHIP_REV_D0     3
> >  #define EP93XX_CHIP_REV_D1     4
> > @@ -34,4 +35,9 @@ static inline unsigned int ep93xx_chip_revision(void) { return 0; }
> >  
> >  #endif
> >  
> > +static inline void ep93xx_regmap_write(struct regmap *map, unsigned int reg, unsigned int val) {}
> > +static inline void ep93xx_regmap_update_bits(struct regmap *map, unsigned int reg,
> > +                                            unsigned int mask, unsigned int val)
> > +{ }
> > +
> >  #endif

-- 
Alexander Sverdlin.