linux-kernel - Re: [PATCH v4 26/42] mtd: nand: add support for ts72xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230918145852.46a15c77@xps-13>
Date:   Mon, 18 Sep 2023 14:58:52 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Nikita Shubin via B4 Relay 
        <devnull+nikita.shubin.maquefel.me@...nel.org>
Cc:     <nikita.shubin@...uefel.me>, Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        Arnd Bergmann <arnd@...db.de>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Liang Yang <liang.yang@...ogic.com>,
        Christophe Kerello <christophe.kerello@...s.st.com>,
        Jean Delvare <jdelvare@...e.de>,
        Johan Jonker <jbx6244@...il.com>, linux-kernel@...r.kernel.org,
        linux-mtd@...ts.infradead.org,
        Alexander Sverdlin <alexander.sverdlin@...il.com>
Subject: Re: [PATCH v4 26/42] mtd: nand: add support for ts72xx

Hi Nikita,

devnull+nikita.shubin.maquefel.me@...nel.org wrote on Fri, 15 Sep 2023
11:11:08 +0300:

> From: Nikita Shubin <nikita.shubin@...uefel.me>
> 
> Technologic Systems has it's own nand controller implementation in CPLD.

I initially agreed to accept a first version of this controller driver
with a legacy API because people were apparently under time pressure to
get this in. I see it's been a couple of months, so this is not that
urgent after all. As the driver is only 166 lines long, I would
strongly prefer a very straight ->exec_op() conversion in order to get
rid of these ugly direct I/O accesses.

Thanks,
Miquèl

> Signed-off-by: Nikita Shubin <nikita.shubin@...uefel.me>
> ---
>  drivers/mtd/nand/raw/Kconfig                       |   7 +
>  drivers/mtd/nand/raw/Makefile                      |   1 +
>  drivers/mtd/nand/raw/technologic-nand-controller.c | 166 +++++++++++++++++++++
>  3 files changed, 174 insertions(+)
>