linux-kernel - Re: [PATCH for-next v2 02/10] PM: Update EXPORT_*_DEV_PM_OPS() to EXPORT_*_RUNTIME_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZQgQilY20yEUPtt3@black.fi.intel.com>
Date:   Mon, 18 Sep 2023 11:55:38 +0300
From:   Raag Jadav <raag.jadav@...el.com>
To:     Paul Cercueil <paul@...pouillou.net>
Cc:     rafael@...nel.org, len.brown@...el.com, pavel@....cz,
        Jonathan.Cameron@...wei.com, andriy.shevchenko@...ux.intel.com,
        lars@...afoo.de, rmfrfs@...il.com, jean-baptiste.maneyrol@....com,
        lee@...nel.org, laurentiu.palcu@....nxp.com,
        l.stach@...gutronix.de, james.schulman@...rus.com,
        david.rhodes@...rus.com, rf@...nsource.cirrus.com,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-iio@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        patches@...nsource.cirrus.com,
        mallikarjunappa.sangannavar@...el.com, bala.senthil@...el.com
Subject: Re: [PATCH for-next v2 02/10] PM: Update EXPORT_*_DEV_PM_OPS() to
 EXPORT_*_RUNTIME_PM_OPS()

On Mon, Sep 18, 2023 at 10:20:29AM +0200, Paul Cercueil wrote:
> Le lundi 18 septembre 2023 à 13:39 +0530, Raag Jadav a écrit :
> > Rename EXPORT_*_DEV_PM_OPS() macros to EXPORT_*_RUNTIME_PM_OPS()
> > and while at it, move them to pm_runtime.h.
> > This is done in conjunction with the introduction of
> > EXPORT_*_SIMPLE_PM_OPS() set of macros, to make things less
> > confusing.
> > This makes both _RUNTIME_ and _SIMPLE_ variants of export macros more
> > distinguishable and self explanatory.
> 
> Well I don't really agree with this one. The EXPORT_*_DEV_PM_OPS() can
> be used with any callback you need, not just the typical runtime-PM
> callbacks. They are generic PM macros.

I agree on the usage part. But with the introduction of export macros for
_SIMPLE_ variants, current naming scheme would make things unnecessarily
confusing to the users in my opinion.

Perhaps we can have it simplified some other way?

Raag